This task is for a new student in MD Systems, don't do it if it was not assigned to you.
Steps to reproduce:
1. Create a job with config entity
2. Remove a config entity
3. Go to job overview - there should be an error message like on the screenshot below:
Very quickly we can have a list of missing labels. We added drupal_set_message() in #2543294: Fatal error when entity deleted.
In /sources/tmgmt_config/src/Plugin/tmgmt/Source/ConfigSource::getLabel(), remove drupal_set_message().
| Comment | File | Size | Author |
|---|---|---|---|
| #13 | test_for_tmgmt_demo-2690095-13.patch | 694 bytes | harivenuv |
| #11 | test_for_tmgmt_demo-2690095-9-10.txt | 427 bytes | harivenuv |
| #10 | interdiff-2690095-8-9.txt | 0 bytes | m13165972293@163.com |
| #10 | test_for_tmgmt_demo-2690095.patch | 700 bytes | m13165972293@163.com |
| #8 | interdiff-2690095-3-6.txt | 698 bytes | m13165972293@163.com |
Comments
Comment #2
tduong commentedComment #3
m13165972293@163.com commentedComment #4
tduong commentedPlease remember to set the issue status to "Needs review" to run the testbot
Comment #5
tduong commentedYou have to delete these lines, not only commenting them :)
Also remember to provide also an interdiff: https://www.drupal.org/documentation/git/interdiff
And assign this issue to yourself.
Comment #6
m13165972293@163.com commentedComment #7
m13165972293@163.com commentedComment #8
m13165972293@163.com commentedComment #10
m13165972293@163.com commentedComment #11
harivenuvhi m13165972293@163.com,
There is a white space in your patch. I have removed the white space and added a interdiff patch.
Comment #12
miro_dietiker@harivenu_zyxware You just uploaded the interdiff and not the patch?
Comment #13
harivenuvhi miro_dietiker,
Oh sorry, I missed that.
Comment #14
miro_dietikerCommitting, plus adding a comment.