Extract DrupalKernel::bootEnvironment into SAPI adapter

Just some quick feedback.

1. +++ b/core/lib/Drupal/Core/SAPI/HttpSAPIAdapter.php
   @@ -0,0 +1,74 @@
   +        // Web tests are to be conducted with runtime assertions active.
   +        assert_options(ASSERT_ACTIVE, TRUE);
   +        // Now synchronize PHP 5 and 7's handling of assertions as much as
   +        // possible.
   +        \Drupal\Component\Assertion\Handle::register();
   
   +++ b/core/lib/Drupal/Core/SAPI/SAPIAdapter.php
   @@ -0,0 +1,46 @@
   +  public function prepareEnvironment($root, $environment) {
   

   Is there a reason why we don't add assertions here?

2. +++ b/core/modules/simpletest/src/WebTestBase.php
   @@ -234,12 +235,20 @@
   +   * The SAPI adapter.
   +   *
   +   * @var \Drupal\Core\SAPI\SAPIAdapterInterface.
   +   */
   +  protected $sapiAdapter;
   

   This variable isn't used

Needs a reroll.

+1 on the idea because separation of concerns is good. Some review stuff:

1. +++ b/core/lib/Drupal/Core/SAPI/CliSAPIAdapter.php
   @@ -0,0 +1,32 @@
   +class CliSAPIAdapter extends SAPIAdapter {
   
   +++ b/core/lib/Drupal/Core/SAPI/HttpSAPIAdapter.php
   @@ -0,0 +1,74 @@
   +class HttpSAPIAdapter extends SAPIAdapter {
   
   +++ b/core/lib/Drupal/Core/SAPI/NullSAPIAdapter.php
   @@ -0,0 +1,30 @@
   +class NullSAPIAdapter implements SAPIAdapterInterface {
   
   +++ b/core/lib/Drupal/Core/SAPI/SAPIAdapter.php
   @@ -0,0 +1,46 @@
   +class SAPIAdapter implements SAPIAdapterInterface {
   
   +++ b/core/lib/Drupal/Core/SAPI/SAPIAdapterInterface.php
   @@ -0,0 +1,34 @@
   +interface SAPIAdapterInterface {
   

   Drupal coding standards say we should CamelCase acronyms: https://www.drupal.org/node/608152#naming

2. +++ b/core/lib/Drupal/Core/SAPI/CliSAPIAdapter.php
   @@ -0,0 +1,32 @@
   +/**
   + * @file
   + * Contains \Drupal\Core\SAPI\CliSAPIAdapter.
   + */
   
   +++ b/core/lib/Drupal/Core/SAPI/HttpSAPIAdapter.php
   @@ -0,0 +1,74 @@
   +/**
   + * @file
   + * Contains \Drupal\Core\SAPI\HttpSAPIAdapter.
   + */
   
   +++ b/core/lib/Drupal/Core/SAPI/NullSAPIAdapter.php
   @@ -0,0 +1,30 @@
   +/**
   + * @file
   + * Contains \Drupal\Core\NullSAPIAdapter.
   + */
   
   +++ b/core/lib/Drupal/Core/SAPI/SAPIAdapter.php
   @@ -0,0 +1,46 @@
   +/**
   + * @file
   + * Contains \Drupal\Core\SAPI\SAPIAdapter.
   + */
   
   +++ b/core/lib/Drupal/Core/SAPI/SAPIAdapterInterface.php
   @@ -0,0 +1,34 @@
   +/**
   + * @file
   + * Contains \Drupal\Core\SAPI\SAPIAdapterInterface.
   + */
   

   We don't use @file tags just for Contains... any more.

3. +++ b/core/rebuild.php
   @@ -25,8 +26,8 @@
    // Manually resemble early bootstrap of DrupalKernel::boot().
   -require_once __DIR__ . '/includes/bootstrap.inc';
   -DrupalKernel::bootEnvironment();
   +$sapi_adapter = SAPIAdapter::createFromGlobals();
   +$sapi_adapter->prepareEnvironment(__DIR__ . '/../', 'prod');
   

   Removing require_once for .inc files makes Mile23 happy. :-)

   (Just to be clear: This isn't something you need to change.)

Looks like core/modules/simpletest/src/BrowserTestBase.php file is almost empty in 8.2.x for now. That's why this reroll is so massive

Rerolled the patch #28

Why is it not showing error? :(

Sorry forget to put newly created files in a last patch.

We are working on this at DrupalCon Dublin

Patch attached

This patch needs reviewed

There's no such thing as 'needs review' tag. Setting the status is fine.

Unfortunately there are quite a few failing tests still, so we're back to 'needs work.'

+++ b/core/lib/Drupal/Core/DrupalKernel.php
@@ -280,18 +281,21 @@ public static function createFromRequest(Request $request, $class_loader, $envir
-    $this->root = $app_root;
+    $this->root = dirname(dirname(substr(__DIR__, 0, -strlen(__NAMESPACE__))));

I'm pretty sure this is a bad re-roll, since we did a bunch of work to inject $app_root.

Are you re-rolling from 8.3.x?

Effort to isolate the test fixture part of bootEnvironment(): #2969741: Deprecate simpletest within DrupalKernel (DRUPAL_TEST_IN_CHILD_SITE)

This could perhaps be achieved with the more modern symfony/runtime component. #3313404: Use symfony/runtime for less bespoke bootstrap/compatibility with varied runtime environments

Closing to focus on common solution #3313404: Use symfony/runtime for less bespoke bootstrap/compatibility with varied runtime environments

Reopening this but postponing on #3313404: Use symfony/runtime for less bespoke bootstrap/compatibility with varied runtime environments so that that issue can remain small and focused on adding the runtime to Drupal but this issue moves over the actual environment set-up.

Coming here from #3453474: CLI entry point in Drupal Core. Ran head-first into this weirdness since the new CLI was trying to call bootEnvironment() but that created a world of hurt for running commands inside tests since bootEnvironment() does the set_error_handler() call yet tests don't want their own error handler to be forgotten. But since bootEnvironment() happens only once ever (due to the static flag), it's hard/impossible for the new DrupalApplication entrypoint to responsibly restore the error handler after it completes. Ideally, we'd have a way to get most of bootEnvironment() without messing with the error handler, so the CLI could get the goods without the headache of swapping error handlers. Or we move the error handler stuff to something that is tied to each DrupalKernel so at least we can safely restore once DrupalKernel is done. Or something. 😅

Re-opening as #3313404: Use symfony/runtime for less bespoke bootstrap/compatibility with varied runtime environments was merged. Setting to Needs work.

Started some of the work from here at #3597692: [regression] The `dr` command doesn't set DRUPAL_TEST_IN_CHILD_SITE to deal with a test-only regression from the new dr CLI entry point.