Problem/Motivation

admin/tmgmt/sources/config/block currently also shows the check for continuous button. Clicking it results in a fatal error.

Proposed resolution

Fix it by checking that the source supports continuous before displaying it.

Also open a follow-up issue to consider supporting continuous translation for config entities too.

Remaining tasks

User interface changes

API changes

Data model changes

CommentFileSizeAuthor
#5 check_for_continuous-2689795-5-interdiff.txt1.19 KBmbovan
#5 check_for_continuous-2689795-5.patch2.25 KBmbovan
#3 check_for_continuous-2689795-3.patch2.82 KBmbovan

Comments

Berdir created an issue. See original summary.

mbovan’s picture

mbovan commented
Assigned: Unassigned » mbovan
mbovan’s picture

mbovan commented
Status: Active » Needs review
StatusFileSize
new check_for_continuous-2689795-3.patch2.82 KB

Fixed and tests.

Followup: #2689863: Support continuous translation for config entities

berdir’s picture

berdir
Primary language German
Location Switzerland
commented 
+++ b/sources/tmgmt_config/src/Tests/ConfigSourceUiTest.php
@@ -23,7 +24,7 @@ class ConfigSourceUiTest extends EntityTestBase {
    */
-  public static $modules = array('tmgmt_config', 'views', 'views_ui', 'field_ui', 'config_translation');
+  public static $modules = array('tmgmt_config', 'views', 'views_ui', 'field_ui', 'config_translation', 'tmgmt_test');

why do we need demo now exactly?

mbovan’s picture

mbovan commented
StatusFileSize
new check_for_continuous-2689795-5.patch2.25 KB
new check_for_continuous-2689795-5-interdiff.txt1.19 KB

Thought that I had to have a translator that supports continuous jobs, but we are creating it through API... Let's save some tests seconds. :)

  • Berdir committed 310a0ea on 8.x-1.x authored by mbovan 
    Issue #2689795 by mbovan: Check for continuous jobs must not be shown...
berdir’s picture

berdir
Primary language German
Location Switzerland
commented
Status: Needs review » Fixed

Great, committed.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.