Remove depreciated methods in code base

CommentFileSizeAuthor
#6 Remove_depreciated-2689767-6.patch555 bytesPurnachandra Rao V
commerce.patch5.97 KBPurnachandra Rao V
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Purnachandra Rao V created an issue. See original summary.

Purnachandra Rao V’s picture

Purnachandra Rao V CreditAttribution: Purnachandra Rao V as a volunteer and at Melity commented
Status: Active » Needs review
agoradesign’s picture

agoradesign CreditAttribution: agoradesign commented

Have you tried out the patch? I didn't, but when I look at the patch contents, I doubt that it'll work for every class, in that you've replaced the EntityManager with the EntityTypeManager - are you sure, that the EntityTypeManager service is already injected everywhere, without changing constructors, factory methods,...

agoradesign’s picture

agoradesign CreditAttribution: agoradesign commented
Title: Drupal Commerce - Remove depreciated methods in code base » Remove deprecated EntityManagerInterface service and Entity::urlInfo() calls

changed the title, marked #2682491: Inject entity type manager and remove the deprecated EntityManagerInterface. as duplicate

bojanz’s picture

bojanz CreditAttribution: bojanz at Centarro commented
Status: Needs review » Needs work

Yes, none of that will work. Please run the tests.
The reason why we use the deprecated EntityManager in these places is because the parent classes (belonging to core) inject and use the EntityManager.

You can reroll the patch with just the urlInfo changes.

Purnachandra Rao V’s picture

Purnachandra Rao V CreditAttribution: Purnachandra Rao V as a volunteer and at Melity commented
FileSize
Remove_depreciated-2689767-6.patch555 bytes

Thanks for update this issue.
please find updated patch.

bojanz’s picture

bojanz CreditAttribution: bojanz at Centarro commented
Title: Remove deprecated EntityManagerInterface service and Entity::urlInfo() calls » Remove urlInfo() call

Retitling

bojanz’s picture

bojanz CreditAttribution: bojanz at Centarro commented
Title: Remove urlInfo() call » Remove usage of deprecated methods
Version: 8.x-2.0-alpha3 » 8.x-2.x-dev
Assigned: Purnachandra Rao V » Unassigned

bojanz’s picture

bojanz CreditAttribution: bojanz at Centarro commented
Status: Needs work » Fixed

Committed, along with another fix of a similar nature. Thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.