Come together with the global Drupal community in Rotterdam, 28 Sept – 1 Oct 2026. Sessions, contribution, connection, and Early Bird savings until 8 June.Remove depreciated methods in code base
| Comment | File | Size | Author |
|---|---|---|---|
| #6 | Remove_depreciated-2689767-6.patch | 555 bytes | Purnachandra Rao V |
| commerce.patch | 5.97 KB | Purnachandra Rao V |
Comments
Comment #2
Purnachandra Rao V commentedComment #3
agoradesign commentedHave you tried out the patch? I didn't, but when I look at the patch contents, I doubt that it'll work for every class, in that you've replaced the EntityManager with the EntityTypeManager - are you sure, that the EntityTypeManager service is already injected everywhere, without changing constructors, factory methods,...
Comment #4
agoradesign commentedchanged the title, marked #2682491: Inject entity type manager and remove the deprecated EntityManagerInterface. as duplicate
Comment #5
bojanz commentedYes, none of that will work. Please run the tests.
The reason why we use the deprecated EntityManager in these places is because the parent classes (belonging to core) inject and use the EntityManager.
You can reroll the patch with just the urlInfo changes.
Comment #6
Purnachandra Rao V commentedThanks for update this issue.
please find updated patch.
Comment #7
bojanz commentedRetitling
Comment #8
bojanz commentedComment #10
bojanz commentedCommitted, along with another fix of a similar nature. Thanks!