First watch the video if you haven't already, it's fun. (Relevant section to this patch starts at 5:30 ish)
What this patch does:
Removes the redundant 'edit' link on admin/build/types and leaves the clickable content type name.
Removes the 'edit' link on the admin/content/taxonomy overview and makes the vocabulary name clickable. I also made some very minor text changes to headers.
Doesn't affect taxonomy or node tests.
| Comment | File | Size | Author |
|---|---|---|---|
| #3 | tax-content_ui2.patch | 1.5 KB | catch |
| tax-content-ui.patch | 3.54 KB | catch |
Comments
Comment #1
pwolanin commented@catch - do we want to go this way? In other cases there is an "edit" link, while the link to the thing takes you to a view page.
Both of these are funny in the sense that the view and edit are the same. I'd almost think we might want to make the taxonomy link to the edit page also and leave the edit?
Comment #2
catchHmm. I always get confused on admin/build/types due to the redundant links and have to hover over them to remind myself where each one goes via the status bar (of course it's to the same place). That might be just me though.
We could also make the 'name' columns not links, I'll probably roll a version like that for comparison (but leaving at needs review for now).
Comment #3
catchHere it is, and I think you're right. With no links on the names, this has the added advantage of differentiating the admin/build/types page from node/add (if only a tiny bit).
Comment #4
senpai commentedCatch, that tiny bit is important. I really like the approach in #3 better than the original patch. Let's go with #3.
Tested against HEAD with a fresh db. Taxonomy and Node Simpletests still pass.
Comment #5
dries commentedSmall but subtle improvements. Committed. Thanks!
Comment #6
Anonymous (not verified) commentedAutomatically closed -- issue fixed for two weeks with no activity.