Problem/Motivation

We have implemented icons and progress bar along the module, now there are some icons that are not needed since they don't need the attention of the user. Also, the progress bar is being displayed for states where the job is finished unnecessarily.

Proposed resolution

Drop icons and delete progress bar for finished states for simplifying UI.

Remaining tasks

User interface changes

API changes

Data model changes

CommentFileSizeAuthor
#9 interdiff-2688421-7-9.txt2.21 KBjohnchque
#9 improve_progress_bar-2688421-9.patch9.11 KBjohnchque
#7 interdiff-2688421-5-7.txt5.08 KBjohnchque
#7 improve_progress_bar-2688421-7.patch8.78 KBjohnchque
#5 interdiff-2688421-2-5.txt6.09 KBjohnchque
#5 improve_progress_bar-2688421-5.patch12.11 KBjohnchque
#2 Screenshot from 2016-03-16 17:47:29.png121.52 KBjohnchque
#2 Screenshot from 2016-03-16 17:47:24.png94.08 KBjohnchque
#2 improve_progress_bar-2688421-2.patch6.03 KBjohnchque

Comments

yongt9412 created an issue. See original summary.

johnchque’s picture

johnchque
Primary language Spanish
Location Bolivia
commented
Status: Active » Needs review
StatusFileSize
new improve_progress_bar-2688421-2.patch6.03 KB
new Screenshot from 2016-03-16 17:47:24.png94.08 KB
new Screenshot from 2016-03-16 17:47:29.png121.52 KB

Deleted the icons for unused states, we still need to discuss if we want to show the unprocessed jobs and inactive job items in their respective overviews, IMHO it looks cleaner now.

miro_dietiker’s picture

miro_dietiker
Location Switzerland
commented

Good work!
Discussed a lot today and we think less icons are a nice step.
And outputting labels for the state where otherwise the progress bar appears is a good idea. For end states, a progress bar is useless.

Once tests fixed, ready to commit. :-)
And yeah, many followups from the discussion to go deeper about how to unify terminology and how we count stuff...

Status: Needs review » Needs work

The last submitted patch, 2: improve_progress_bar-2688421-2.patch, failed testing.

johnchque’s picture

johnchque
Primary language Spanish
Location Bolivia
commented
Status: Needs work » Needs review
StatusFileSize
new improve_progress_bar-2688421-5.patch12.11 KB
new interdiff-2688421-2-5.txt6.09 KB

Tests fixed. Should be fine. :)

Status: Needs review » Needs work

The last submitted patch, 5: improve_progress_bar-2688421-5.patch, failed testing.

johnchque’s picture

johnchque
Primary language Spanish
Location Bolivia
commented
Status: Needs work » Needs review
StatusFileSize
new improve_progress_bar-2688421-7.patch8.78 KB
new interdiff-2688421-5-7.txt5.08 KB

OK, I wanted to include the change from Needs review to Needs work but it seems it is a big change and it breaks a lot of tests, maybe better to create a followup for it. Now just focusing on simplifying icons.

miro_dietiker’s picture

miro_dietiker
Location Switzerland
commented
Status: Needs review » Needs work 
+++ b/src/Plugin/views/field/Progress.php
@@ -21,14 +23,39 @@ class Progress extends StatisticsBase {
   public function render(ResultRow $values) {

+++ b/tmgmt.module
@@ -1016,18 +1008,6 @@ function tmgmt_color_job_legend() {
-      'legend' => t('Rejected'),

I don't see this state here provided?

johnchque’s picture

johnchque
Primary language Spanish
Location Bolivia
commented
Status: Needs work » Needs review
StatusFileSize
new improve_progress_bar-2688421-9.patch9.11 KB
new interdiff-2688421-7-9.txt2.21 KB

True! Now should be OK.

miro_dietiker’s picture

miro_dietiker
Location Switzerland
commented
Status: Needs review » Fixed

Committed, yay! :-)

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.