Display source and target language in the local translator task item header area and add test coverage.

CommentFileSizeAuthor
#9 local_task_item_form.png32.74 KBsanja_m
#9 2688181-9.patch1.64 KBsanja_m
#8 Screen Shot 2016-03-22 at 24.29.26 .png12.06 KBmiro_dietiker
#8 Screen Shot 2016-03-22 at 24.29.06 .png10.74 KBmiro_dietiker
#5 task_item_form.png76.51 KBsanja_m
#5 2688181-5.patch2.02 KBsanja_m

Comments

sanja_m created an issue. See original summary.

sanja_m’s picture

sanja_m commented
Assigned: Unassigned » sanja_m

Assigning to me.

sanja_m’s picture

sanja_m commented
Title: Display language from + to in local task item form » Add test coverage for displaying languages in local task item form
Issue summary: View changes
sanja_m’s picture

sanja_m commented
Title: Add test coverage for displaying languages in local task item form » Display language from + to in local task item form
Issue summary: View changes

Reverting issue title, because realized we still need to display languages next to the fields that are added in #2680119: Let translators view unpublished or protected source content

sanja_m’s picture

sanja_m commented
Status: Active » Needs review
StatusFileSize
new 2688181-5.patch2.02 KB
new task_item_form.png76.51 KB

Added patch and screenshot.

  • Berdir committed 0680721 on 8.x-1.x authored by sanja_m 
    Issue #2688181 by sanja_m: Display language from + to in local task item...
berdir’s picture

berdir
Primary language German
Location Switzerland
commented
Status: Needs review » Fixed

Looks good.

miro_dietiker’s picture

miro_dietiker
Location Switzerland
commented
Issue summary: View changes
Status: Fixed » Needs work
StatusFileSize
new Screen Shot 2016-03-22 at 24.29.06 .png10.74 KB
new Screen Shot 2016-03-22 at 24.29.26 .png12.06 KB

Yeah good to have it here in local translator also.

Still reopening since the review form lists the review item as "Source" and "Target" label while the local task displays the source language and the target language as a label.
This, however is redundant with the header consistently output.

IMHO we should switch to "Source" and "Target" like the review form consistently.

sanja_m’s picture

sanja_m commented
Status: Needs work » Needs review
StatusFileSize
new 2688181-9.patch1.64 KB
new local_task_item_form.png32.74 KB

Switched to "Source" and "Translation" like in the review form.

miro_dietiker’s picture

miro_dietiker
Location Switzerland
commented
Status: Needs review » Fixed

Thx, committed. :-)

  • miro_dietiker committed 1691f71 on 8.x-1.x authored by sanja_m 
    Issue #2688181 by sanja_m: Display language from + to in local task item...
berdir’s picture

berdir
Primary language German
Location Switzerland
commented
Status: Needs review » Fixed

Grml.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.