When editing a Document stored in a Files section, clicking Do not send notifications for this update causes that option to disappear. Screenshots before and after click attached.

Comments

thekenshow created an issue. See original summary.

mpotter’s picture

Hmm, are you sure you are using the dev version of oa_notifications? I could not reproduce this one. Tried it on the Add, Edit, and View pages and clicking the Do not send... checkbox didn't disappear on any of those for document pages in a Files section.

Can you tell me which page you were on that saw this? Also, are comments enabled on that page?

mpotter’s picture

Ah ha, got it...

If you are on the Edit form of the document page and comments are disabled, then the Do not send... option seems to disappear. Working on it.

thekenshow’s picture

> are on the Edit form of the document page and comments are disabled

Yes, that’s exactly where I am. I’m going to have to write more detailed essays so you don’t need a ouija board to figure out my situation ;-)

mpotter’s picture

OK, let's try this! Committed a3bbb64 to oa_notification, so pull the latest dev and try it again.

mpotter’s picture

Status: Active » Fixed
mpotter’s picture

For other people who might be watching: This is probably the most complicated functionality I've implemented in a long time, and it's one of those things that is ridiculously hard to test via automated testing. There are lots of different combinations of 1) node add/edit/view pages, 2) the Override checkbox (ajax), the Textfield for adding things (ajax plus autocomplete), the X buttons for removing (ajax) the Do Not Send checkbox (ajax) and the Expand all (ajax), 3) and the exact order of these different elements that you interact with.

For example "Checking the Do Not Send checkbox After clicking the X button to remove somebody, when on the Node Edit form".

It would probably take me longer to write tests for all of this than it has to write the actual functionality! (Ajax tests are some the hardest to write and debug)

Anyway, I *really* appreciate getting real human testing on this system. It's important to get it right.

thekenshow’s picture

Installed, tested, looks good. The checkbox works, stays in place. When I check it and then save, and then edit, it’s restored to unchecked - as I expected.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.