cacheUntilEntityChanges() is deprecated and should be replaced with addCacheableDependency()

Good find, thanks!

Initial Try.

@sidharthap: Thanks for the patch. Since this is only ever used for documentation and not actually code that is executed we can directly change it without any deprecation notice though.

@tstoeckler thank you. is it mean we can directly remove cacheUntilEntityChanges() from the code by using addCacheableDependency()
for Version: 8.0.x-dev also?

@sidharthap: Yup, exactly.

Thank you @tstoeckler
Updated patch as per #6. it is only remove from block.api.php.

Yay, thanks a lot. Looks great.

See https://www.drupal.org/core/scope - we should replace all the usages of cacheUntilEntityChanges() in core so we are consistent.

@alexpott

Agreed. Should a new issue be opened or should the novice tag be removed from this issue?

I changed the issue title - so let's use this one. Afaics this is still a novice issue.

updated patch, removed from all the files as per comment #10. I think we can have a separate issue to remove the function cacheUntilEntityChanges() from
core\lib\Drupal\Core\Access\AccessResult.php file.

$ grep 'cacheUntilEntityChanges' -R .
./core/lib/Drupal/Core/Access/AccessResult.php:  public function cacheUntilEntityChanges(EntityInterface $entity) {

The patch itself is great. However, it only applies to 8.0. We should get this in to 8.2 first, so the patch needs to be rerolled.
I personally think we should at least fix the docs in 8.1 and 8.0 as well, but not sure what others think.

Here is a patch for 8.2.x

Yup, this one is good to go for 8.2. (It applies to 8.1 as well, but I guess it's too late for that, if I'm not mistaken.)

$ grep 'cacheUntilEntityChanges' -R . | wc -l
52
$ curl https://www.drupal.org/files/issues/updating-deprications-2686765-15.patch | git apply --index
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100 31740  100 31740    0     0  47318      0 --:--:-- --:--:-- --:--:-- 47302
$ grep 'cacheUntilEntityChanges' -R . | wc -l
1
$ grep 'cacheUntilEntityChanges' -R .
./core/lib/Drupal/Core/Access/AccessResult.php:  public function cacheUntilEntityChanges(EntityInterface $entity) {

Committed/pushed to 8.2.x, thanks!

I'd personally put this into 8.1.x as well since we have a second beta to put out still. It's not newly deprecating anything, just removing deprecated usages. But leaving RTBC against 8.1.x in case someone else thinks it is too late.

One advantage of having this in 8.1.x is it will allow us to actively deprecate the function in 8.2.x with trigger_error() if we want.

Sure, even better!

Yay! Thanks :)

+1 for 8.1.x.

I am re-rolling this patch.

@sashi.kiran it applies to 8.1.x so there is no need to do a reroll.

More unrelated test fails..

Taking lack of comment as agreement to put this in 8.1.x too, so cherry-picked there as well. Thanks all.

So the original bug report, i.e. the false documentation on https://api.drupal.org/api/drupal/core!modules!block!block.api.php/funct... is not yet fixed. I don't know in how far api.drupal.org already supports the semantic versioning and what the plans are regarding that, but IMHO it would be nice to commit #7 (i.e. just the docs change) to 8.0, as well. Thoughts?

I don't think fixing this documentation in 8.0.x is necessary... as far as I remember api.d.o is already on 8.1.x

Back to fixed.

Sorry to be somewhat obnoxious, but visiting https://api.drupal.org/api/drupal/core!modules!block!block.api.php/funct... still gives the old code, so not sure about #30

@tstoeckler you have to wait for it run cron I don't think it reflects changes immediately

Why did the patch not apply properly?

You're right about api.drupal.org, however there's an issue to fix it at #2662812: Figure out how to deal with multiple 8.x branches.

8.0.x won't be getting any further commits unless there's a security release, so moving this to closed again.

Ahh OK, fine. Thanks for the link.