Note: I'm using commit b27f331 to oa_notifications.
Working on parent Space with nothing above it, if I change one configured notification set (e.g., the Group associated with the Space) to a different set (e.g., a Team within that Apace), and I select Do not send notifications, and click Save, the following happens:
1) The green Space ABC has been updated message appears.
2) A red message box appears, stating:
Notice: Undefined index: #ajax in ajax_form_callback() (line 395 of /Users/kendow/Sites/firetech.local/includes/ajax.inc).
The content on this page has either been modified by another user, or you have already submitted modifications using this form. As a result, your changes cannot be saved.
3) The edit form continues to display.
If I click Cancel, then return to editing again, the change I made has actually been applied, e.g., the Team is now configured for notification.
Another smaller problem: If I remove all notification sets so that nothing is listed for the Space, and click Do not send notifications, the checkbox and that text disappears. Clicking Save still works correctly, and return to editing shows no configured notifications, as expected.
| Comment | File | Size | Author |
|---|---|---|---|
| #3 | oa_notifications_source.png | 93.65 KB | thekenshow |
| #3 | oa_notifications_rendered.png | 20.53 KB | thekenshow |
Comments
Comment #2
mpotter commentedReproduced this. I think it's fixed in the new commit dedf587 of oa_notifications so give the latest dev version a try. (Still working on your other reported issue with sections).
Comment #3
thekenshow commentedInstalled dedf587 and the Do not send notifications check box does not appear at all, so I can’t select it to test. Tried with and without Override notifications selected, not visible. Changed from a notify user to notify team, do not see Do not send notifications option. Attached rendered and raw HTML screenshots.
Comment #4
mpotter commentedThat is correct. The "Do not send notifications" box is no longer shown on Space and Section pages in the "Default Notifications" section. The idea is that you are setting the defaults for other content in the space/section and shouldn't be triggering notifications yourself. So it defaults the skip option to TRUE so you are not notified.
But you might want to test the behavior on other content nodes where the Skip option is available. The bug had nothing to do with being on a space/section or not...it caused the same error on other content types.
Comment #5
thekenshow commentedUnderstood, works as intended then - thanks!