https://api.drupal.org/api/drupal/core!lib!Drupal!Core!Asset!LibraryDisc...

$cache and $lock properties are declared already in the CacheCollector abstract class.

CommentFileSizeAuthor
#3 2686595-library-3.patch702 bytessidharthap
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Chi created an issue. See original summary.

snehi’s picture

snehi CreditAttribution: snehi as a volunteer and at Publicis Sapient for Publicis Sapient commented

From where i have to remove these ?

sidharthap’s picture

sidharthap
Primary language English
CreditAttribution: sidharthap at TATA Consultancy Services for Pfizer, Inc. commented
Status: Active » Needs review
FileSize
2686595-library-3.patch702 bytes

Here is a patch which remove $cache and $link from LibraryDiscoveryCollector class.

Chi’s picture

Chi CreditAttribution: Chi commented
Status: Needs review » Reviewed & tested by the community

  • catch committed 6842e77 on 8.2.x 
    Issue #2686595 by sidharthap: LibraryDiscoveryCollector does not need to...

  • catch committed ee3ff7a on 8.1.x 
    Issue #2686595 by sidharthap: LibraryDiscoveryCollector does not need to...
catch’s picture

catch
he/him
Primary language English
CreditAttribution: catch at Third and Grove commented
Status: Reviewed & tested by the community » Fixed

Committed/pushed to 8.2.x and cherry-picked to 8.1.x. Thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.