Problem/Motivation

Steps to reproduce:
- Create a job and submit it to a local translator
- Log in as a local translator
- Click on the assigned local task item
- Provide a translation
- Save translation
- Open the same local task item page for translation

At this point I would expect to see source text and updated translation on the right side, but it looks like that both fields (source and translation) are updated with translation.

Default text.

Updated source text.

CommentFileSizeAuthor
#7 interdiff-do_not_update_source-2685815-4-7.txt2.24 KBedurenye
#7 do_not_update_source-2685815-7.patch8.86 KBedurenye
#4 do_not_update_source-2685815-4.patch9.03 KBedurenye
local_changed.png28.11 KBmbovan
local_default.png28.34 KBmbovan

Comments

mbovan created an issue. See original summary.

berdir’s picture

berdir
Primary language German
Location Switzerland
commented

#2682337: Add the preview feature to translator local has fixes for this. Lets extract that part from that issue into this.

edurenye’s picture

edurenye commented
Assigned: Unassigned » edurenye
edurenye’s picture

edurenye commented
Status: Active » Needs review
StatusFileSize
new do_not_update_source-2685815-4.patch9.03 KB

Done.

berdir’s picture

berdir
Primary language German
Location Switzerland
commented 
+++ b/translators/tmgmt_local/src/Form/LocalTaskItemForm.php
@@ -345,4 +345,35 @@ class LocalTaskItemForm extends ContentEntityForm {
+  private function prepareDate(array $translation, $key = array()) {
+    if (isset($translation['#text'])) {
+      if (isset($translation['#translation']['#text'])) {
+        $translation['#text'] = $translation['#translation']['#text'];
+      }
+      else {
+        $translation['#text'] = '';
+      }
+      return $translation;
+    }
+    foreach (Element::children($translation) as $item) {
+      $translation[$item] = $this->prepareDate($translation[$item], array_merge($key, array($item)));

Not convinced this makes sense yet. Lets go through this together.

miro_dietiker’s picture

miro_dietiker
Location Switzerland
commented
Priority: Normal » Major

Still the bug looks severe. Raising prio to get attention.

edurenye’s picture

edurenye commented
StatusFileSize
new do_not_update_source-2685815-7.patch8.86 KB
new interdiff-do_not_update_source-2685815-4-7.txt2.24 KB

Done the changes proposed by @Berdir

  • Berdir committed 8da9ceb on 8.x-1.x authored by edurenye 
    Issue #2685815 by edurenye: Do not update source text after saving a...
berdir’s picture

berdir
Primary language German
Location Switzerland
commented
Status: Needs review » Fixed

Thanks, committed.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.