I detected that the radio button Leave case the same as source token values. on admin/config/search/path/settings is unchecked if you select that value. Please see the attached screenshot. As far as i can say the value for case is stored correctly and the functionality is given. It seems to be a UI - Issue.

CommentFileSizeAuthor
#6 radio_is_not_checked-2685591-6.patch2.53 KBdermario
#3 radio_is_not_checked-2685591-3.patch631 bytesdermario
pathauto-case-unchecked.png64.11 KBdermario

Comments

dermario created an issue. See original summary.

dermario’s picture

dermario
Primary language German
Location Zürich
commented
Issue summary: View changes
dermario’s picture

dermario
Primary language German
Location Zürich
commented
Assigned: Unassigned » dermario
Status: Active » Needs review
StatusFileSize
new radio_is_not_checked-2685591-3.patch631 bytes

It seems like the boolean FALSE is not a valid default value for the checkbox. A simple cast to integer seems to solve that problem.

berdir’s picture

berdir
Primary language German
Location Switzerland
commented
Status: Needs review » Needs work

The values of those constants is 0 and 1, not TRUE and FALSE.

We should change the type of the schema to integer then. Then it will be saved as that and should work correctly.

Now that the other issue is committed, it should be possible to check this as well without too much additional code?

dave reid’s picture

dave reid
he/him
Primary language English
Location Nebraska USA
commented

Huh, I didn't realize this radio UI came from D7. I would actually propose to simplify just with a checkbox for '[x] Convert token values to lowercase.'

dermario’s picture

dermario
Primary language German
Location Zürich
commented
Status: Needs work » Needs review
StatusFileSize
new radio_is_not_checked-2685591-6.patch2.53 KB

I followed the suggestion of Dave in #5 and converted the radios into one checkbox and adjusted the tests.

berdir’s picture

berdir
Primary language German
Location Switzerland
commented
Status: Needs review » Reviewed & tested by the community
Issue tags: -Needs tests

That works for me.

Yes, the settings form is not very usable, there are probably more things that can be improved.

Will commit this soon.

berdir’s picture

berdir
Primary language German
Location Switzerland
commented
Status: Reviewed & tested by the community » Fixed

Thanks, committed.

  • Berdir committed 7da80a4 on 8.x-1.x authored by dermario 
    Issue #2685591 by dermario: Radio is not checked when choosing "Leave...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.