Backport #2559955: Ensure that Quick Edit relies less on the structure of the HTML.

CommentFileSizeAuthor
#7 revert-ensure-quickedit-relies-less-html-structure-2685191-7.patch1.38 KBnmillin
#2 2685191-2.patch1.38 KBdevin carlson

Comments

Devin Carlson created an issue. See original summary.

devin carlson’s picture

devin carlson commented
Status: Active » Needs review
StatusFileSize
new 2685191-2.patch1.38 KB

A patch which backports #2559955: Ensure that Quick Edit relies less on the structure of the HTML.

devin carlson’s picture

devin carlson commented
Status: Needs review » Fixed

Tested #2 and committed to Quick Edit 7.x-1.x.

  • Devin Carlson committed 0a59107 on 7.x-1.x 
    Issue #2685191 by Devin Carlson: Ensure that Quick Edit relies less on...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented
Related issues: +#2559955: Ensure that Quick Edit relies less on the structure of the HTML, +#2671202: [regression] Text field's label is duplicated in the value when edited & saved using Quick Edit

This caused a regression: #2671202: [regression] Text field's label is duplicated in the value when edited & saved using Quick Edit.

nmillin’s picture

nmillin commented
StatusFileSize
new revert-ensure-quickedit-relies-less-html-structure-2685191-7.patch1.38 KB

If someone comes across this issue, I've attached a patch reverting this commit. Changing the class selecting the content to quickedit caused 2 wrapping divs (.field-items & .field-item) to be saved whenever a page was quickedited.