Hey there,
I noticed an issue with the wetkit Twitter Bean.

Currently, the bean allows you to select the number of tweets to show.
But after looking at twitters embed documentation - there is an issue.

A twitter embed CANNOT have a tweet limit AND have a height set.

I think there should be an additional field added to the twitter bean which would allow the user to select one or the other.
A height to the twitter bean, or a tweet limit.

Thanks

CommentFileSizeAuthor
#7 wetkit_bean_twitter_height-and-tweet-limit.patch2.94 KBaastrong
#6 wetkit_bean_twitter_height-and-tweet-limit.txt2.94 KBaastrong
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

aastrong created an issue. See original summary.

aastrong’s picture

aastrong CreditAttribution: aastrong commented

A patch to follow,

aastrong’s picture

aastrong CreditAttribution: aastrong commented

Created pull request / patch here
https://github.com/wet-boew-wem/wetkit-bean/pull/3

sylus’s picture

sylus CreditAttribution: sylus commented
Status: Active » Fixed

Committed and attributed! Thx a bunch!

aastrong’s picture

aastrong CreditAttribution: aastrong commented

Woot woot ! Thanks @sylus

aastrong’s picture

aastrong CreditAttribution: aastrong commented
FileSize
wetkit_bean_twitter_height-and-tweet-limit.txt2.94 KB

And just in case anyone wanted to see or apply a patch - here you are.

aastrong’s picture

aastrong CreditAttribution: aastrong commented
FileSize
wetkit_bean_twitter_height-and-tweet-limit.patch2.94 KB

  • sylus committed 00f35bc on 7.x-4.x authored by aastrong 
    Fixed WetKit Bean for Issue #2685101 by aastrong: Issue with wetkit...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.