I imported multiple XLS files today with the new version 7.x-2.1.

Noticed that on files with more than 19 rows (not including the header), only 19 rows were imported.

Tried the same files as CSV files and all rows were successfully imported.

Work around: split the XLS files into multiple files with 19 or less rows.

Both the XLS and CSV importers are attached in text files.

CommentFileSizeAuthor
#15 XLS_Import_Bug_2684323.patch2.82 KBsinasalek
#14 XLS_Import_Bug_2684323.patch3.04 KBsinasalek
#9 node data.xls112.5 KBsosyuki
#9 XLS_Import_Bug_2684323-9.patch3.22 KBsosyuki
#7 node data.xls84 KBsosyuki
#7 12 Import after Node 3.png143.69 KBsosyuki
#7 10 Import after Node 1.png84.82 KBsosyuki
#7 11 Import after Node 2.png46.41 KBsosyuki
#7 9 Import before Node.png21.1 KBsosyuki
#7 8 Mapping for Node processor.png61.61 KBsosyuki
#7 7 Settings for Node processor.png86.72 KBsosyuki
#7 6 Processor.png61.17 KBsosyuki
#7 5 Excel parser.png65.4 KBsosyuki
#7 4 Parser.png62.64 KBsosyuki
#7 3 File upload.png58.81 KBsosyuki
#7 2 Fetcher.png46.02 KBsosyuki
#7 1 Basic settings.png77.42 KBsosyuki
#5 7 - Node Processor.png40.31 KBjaredcampbell
#5 6 - Processor.png26.97 KBjaredcampbell
#5 5 - Excel Parser.png24.37 KBjaredcampbell
#5 4 - Parser.png29.29 KBjaredcampbell
#5 3 - File upload.png22.29 KBjaredcampbell
#5 2 - Fethcher.png25.48 KBjaredcampbell
#5 1 - basic-settings.png33.34 KBjaredcampbell
feeds_excel-csv_importer.txt3.11 KBjaredcampbell
feeds_excel-xls_importer.txt3.24 KBjaredcampbell

Comments

jaredcampbell created an issue. See original summary.

aolaze’s picture

aolaze commented

I have same problem,but i set to 200 rows on Settings for Excel parser.

sosyuki’s picture

sosyuki commented

But if sheet more than 200 rows.Set to 200 rows also don't import 200+ data.

mrromios’s picture

mrromios commented

Can you send screenshot of you settings?

jaredcampbell’s picture

jaredcampbell commented
StatusFileSize
new 1 - basic-settings.png33.34 KB
new 2 - Fethcher.png25.48 KB
new 3 - File upload.png22.29 KB
new 4 - Parser.png29.29 KB
new 5 - Excel Parser.png24.37 KB
new 6 - Processor.png26.97 KB
new 7 - Node Processor.png40.31 KB

I didn't include the author user name or the mapping settings. Would prefer not to post user and database information. If that's required, then I'd be willing to share directly via email.

mrromios’s picture

mrromios commented

And with this settings ExcelParser parses only 200 rows?

sosyuki’s picture

sosyuki commented
StatusFileSize
new 1 Basic settings.png77.42 KB
new 2 Fetcher.png46.02 KB
new 3 File upload.png58.81 KB
new 4 Parser.png62.64 KB
new 5 Excel parser.png65.4 KB
new 6 Processor.png61.17 KB
new 7 Settings for Node processor.png86.72 KB
new 8 Mapping for Node processor.png61.61 KB
new 9 Import before Node.png21.1 KB
new 11 Import after Node 2.png46.41 KB
new 10 Import after Node 1.png84.82 KB
new 12 Import after Node 3.png143.69 KB
new node data.xls84 KB

My settings and node data.

jaredcampbell’s picture

jaredcampbell commented

With my settings, only 19 rows are parsed. XLS files with fewer than 19 rows are processed without a problem. More than 19 rows, nothing is processed beyond row 19.

sosyuki’s picture

sosyuki commented
StatusFileSize
new XLS_Import_Bug_2684323-9.patch3.22 KB
new node data.xls112.5 KB

This bug patch.

jerry’s picture

jerry commented
Status: Active » Needs review

The patch in #9 works for me. Thanks!

jaredcampbell’s picture

jaredcampbell commented

Sorry for the delay in testing this...

Patch #9 worked in our testing environment. Moving over to production and will test again next week.

jaredcampbell’s picture

jaredcampbell commented

We've had Patch #9 in production for a few weeks now and everything seems to be working.

Have imported upwards of 35 rows at a time without problem.

Thanks for the fix!

Alexandre360’s picture

Alexandre360 commented
Priority: Normal » Critical
Status: Needs review » Reviewed & tested by the community

Hello,

I had a excel with more than 20k rows and, before this patch, the import stopped after 3000 rows. Applied the patch and it works.

Seems critical to me as it's a bug that can have a big impact on business if you don't notice that your import stopped...

sinasalek’s picture

sinasalek commented
StatusFileSize
new XLS_Import_Bug_2684323.patch3.04 KB

Fix #9 works, however the patch does not apply due to formatting issue. also it contains some unused codes and comments as well
Here is the cleaned up version.

sinasalek’s picture

sinasalek commented
StatusFileSize
new XLS_Import_Bug_2684323.patch2.82 KB

Line ending and path correction

mrromios’s picture

mrromios commented

Hi guys!
Sorry that didn't have a time to check it.
This patch works, but it is not very good solution for performance - you just run looping of all rows to find total.
I will check it right now and push fixes.
Thanks

mrromios’s picture

mrromios commented

As expected, it was issue with pointers. So, fixed now. Welcome to test new release!!!

mrromios’s picture

mrromios commented
Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

sinasalek’s picture

sinasalek commented