Improve migrate UI tests

This will fail.

This fixes the telephone field migration... I'm not sure that failed is the correct status if the telephone module is not installed on the destination... but that is not the point of this patch.

So this patch should be green - and now we have proper testing of setting the source_base_path through the UI!

Hmmm weird... that test passes locally for me...

Ah my gitignore causing me an issue... missing the temp file...

Rerolled on top of the plugins patch - until that is in 8.1.x this is only eligible for 8.2.x

The only thing that had to change was how we loaded the migrations to see if they were successful.

commit 080d305537fac91f8a055bb1fbbb542023ebf473
Author: Alex Pott <alex.a.pott@googlemail.com>
Date:   Wed Mar 9 14:04:37 2016 +0000

    Fix migration loading

diff --git a/core/modules/migrate_drupal_ui/src/Tests/MigrateUpgradeTestBase.php b/core/modules/migrate_drupal_ui/src/Tests/MigrateUpgradeTestBase.php
index 573f687..af91b4d 100644
--- a/core/modules/migrate_drupal_ui/src/Tests/MigrateUpgradeTestBase.php
+++ b/core/modules/migrate_drupal_ui/src/Tests/MigrateUpgradeTestBase.php
@@ -8,14 +8,15 @@
 namespace Drupal\migrate_drupal_ui\Tests;
 
 use Drupal\Core\Database\Database;
-use Drupal\migrate\Entity\Migration;
 use Drupal\migrate\Plugin\MigrateIdMapInterface;
+use Drupal\migrate_drupal\MigrationCreationTrait;
 use Drupal\simpletest\WebTestBase;
 
 /**
  * Provides a base class for testing migration upgrades in the UI.
  */
 abstract class MigrateUpgradeTestBase extends WebTestBase {
+  use MigrationCreationTrait;
 
   /**
    * Use the Standard profile to test help implementations of many core modules.
@@ -153,8 +154,11 @@ protected function testMigrateUpgrade() {
       $this->assertEqual($expected_count, $real_count, "Found $real_count $entity_type entities, expected $expected_count.");
     }
 
-    /* @var \Drupal\migrate\Entity\Migration $migration */
-    foreach (Migration::loadMultiple() as $migration) {
+    $version_tag = 'Drupal ' . $this->getLegacyDrupalVersion($this->sourceDatabase);
+    $plugin_manager = \Drupal::service('plugin.manager.migration');
+    /** @var \Drupal\migrate\Plugin\Migration[] $all_migrations */
+    $all_migrations = $plugin_manager->createInstancesByTag($version_tag);
+    foreach ($all_migrations as $migration) {
       $id_map = $migration->getIdMap();
       foreach ($id_map as $source_id => $map) {
         $source_id_values = array_values(unserialize($source_id));

Basically we can use the MigrationCreationTrait to do this for us.

#12 got tested against 8.1.x and not 8.2.x... testing now against 8.2.x

For reasons I don't quite understand the id map is really tricky to work with :( - added a comment. But this is not the fault of this issue.