Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Problem/Motivation
Patches that add new kernel tests to 8.0.x (e.g. #2644088: DefaultTableMapping::getFieldTableName does not report table for fields with dedicated storage) should be able to use the same EntityKernelTestBase
base test class that was committed only to 8.1.x and 8.2.x.
Proposed resolution
Backport the test class to 8.0.x.
Remaining tasks
None.
User interface changes
Nope.
API changes
Api addition: a new base test class is available for entity unit tests based on PHPUnit.
Data model changes
Nope.
Comment | File | Size | Author |
---|---|---|---|
#2 | 2683391.patch | 3.72 KB | amateescu |
Comments
Comment #2
amateescu CreditAttribution: amateescu for Pfizer, Inc. commentedLet's try this.
Comment #3
BerdirWhen discussing with alexpott, @dawehner and I discussed that it shouldn't be needed to backport the other issue.
I think it's enough if contrib tests work with the current and upcoming minor version, so once 8.1.x is out, you could convert to the new one.
But I'm also OK if someone thinks this is important enough. Just the base class is certainly already better and less disruption.
Comment #4
amateescu CreditAttribution: amateescu for Pfizer, Inc. commentedIMO the disruption is 0 and it lets patches like #2644088: DefaultTableMapping::getFieldTableName does not report table for fields with dedicated storage be in sync for all three branches.
Comment #5
kevin.dutra CreditAttribution: kevin.dutra at Workday, Inc. commentedA little minor code style cleanup:
$maxDepth
and$ignoreCase
should be lowercase with underscores.Comment #6
amateescu CreditAttribution: amateescu for Pfizer, Inc. commentedThis is just a part of the patch that was committed in #2679096: Convert Kernel Tests in Drupal\system\Tests\Entity to phpunit. I think the arguments were not changed to fit our coding standards in order to be consistent with the parent method.
Comment #7
kevin.dutra CreditAttribution: kevin.dutra at Workday, Inc. commentedAh, okay -- I guess I'll defer to the original issue on that. Since this change is pretty minor, low impact, and helps to avoid reworking patches among the different 8.x branches, I'm going to go ahead and mark this RTBC.
Comment #9
catchI had to double check on 3v4l.org that callers of this won't get a message, but it's only the other way 'round that you get E_DEPRECATED if you call it the wrong way.
Committed/pushed to 8.0.x, thanks!