Convert Kernel Tests in Drupal\system\Tests\Entity to phpunit

Great work!

+++ b/core/tests/Drupal/KernelTests/AssertLegacyTrait.php
@@ -59,7 +59,7 @@ public static function assertFalse($actual, $message = '') {
   protected function assertEqual($actual, $expected, $message = '') {
-    $this->assertEquals($expected, $actual, $message);
+    $this->assertEquals($this->castSafeStrings($expected), $this->castSafeStrings($actual), $message);
   }

IMHO we should fix this is KernelTestBase::assertEquals instead

In my debugging this seems to be really caused by \Drupal\field_test\Plugin\Field\FieldType\TestItem::fieldSettingsFromConfigData believing in runtime casting after loading, which of course doesn't exist.

1. +++ b/core/tests/Drupal/KernelTests/AssertLegacyTrait.php
   @@ -59,7 +59,7 @@ public static function assertFalse($actual, $message = '') {
   -    $this->assertEquals($expected, $actual, $message);
   +    $this->assertEquals($this->castSafeStrings($expected), $this->castSafeStrings($actual), $message);
   

   Is this in scope?

2. +++ b/core/tests/Drupal/KernelTests/Core/Entity/EntityKernelTestBase.php
   @@ -101,7 +99,7 @@ protected function setUp() {
   -      $role = Role::create(array(
   +      $role = entity_create('user_role', array(
   
   @@ -110,10 +108,10 @@ protected function createUser($values = array(), $permissions = array()) {
   -    $account = User::create($values + [
   +    $account = entity_create('user', $values + array(
   ...
   -    ]);
   +    ));
   
   +++ b/core/tests/Drupal/KernelTests/Core/Entity/EntityTranslationTest.php
   @@ -2,16 +2,17 @@
   +use Drupal\KernelTests\Core\Entity\EntityLanguageTestBase;
   
   +++ b/core/tests/Drupal/KernelTests/Core/Entity/EntityTypeConstraintValidatorTest.php
   @@ -2,11 +2,12 @@
   +use Drupal\system\Tests\Entity\EntityUnitTestBase;
   
   +++ b/core/tests/Drupal/KernelTests/Core/Entity/FieldSqlStorageTest.php
   @@ -2,16 +2,17 @@
   +use Drupal\system\Tests\Entity\EntityUnitTestBase;
   
   +++ b/core/tests/Drupal/KernelTests/Core/Entity/FieldTranslationSqlStorageTest.php
   @@ -2,14 +2,15 @@
   +use Drupal\KernelTests\Core\Entity\EntityLanguageTestBase;
   

   These changes look wrong, or at least some of them.

3. +++ b/core/tests/Drupal/KernelTests/Core/Field/FieldSettingsTest.php
   @@ -27,8 +27,8 @@ class FieldSettingsTest extends EntityUnitTestBase {
   -   * @covers \Drupal\Core\Field\BaseFieldDefinition::getSettings()
   -   * @covers \Drupal\Core\Field\BaseFieldDefinition::setSettings()
   +   * @covers \Drupal\Core\Field\BaseFieldDefinition::getSettings
   +   * @covers \Drupal\Core\Field\BaseFieldDefinition::setSettings
   
   @@ -52,8 +52,8 @@ public function testBaseFieldSettings() {
   -   * @covers \Drupal\field\Entity\FieldStorageConfig::getSettings()
   -   * @covers \Drupal\field\Entity\FieldStorageConfig::setSettings()
   +   * @covers \Drupal\field\Entity\FieldStorageConfig::getSettings
   +   * @covers \Drupal\field\Entity\FieldStorageConfig::setSettings
   
   @@ -79,8 +79,8 @@ public function testConfigurableFieldStorageSettings() {
   -   * @covers \Drupal\field\Entity\FieldStorageConfig::getSettings()
   -   * @covers \Drupal\field\Entity\FieldStorageConfig::setSettings()
   +   * @covers \Drupal\field\Entity\FieldStorageConfig::getSettings
   +   * @covers \Drupal\field\Entity\FieldStorageConfig::setSettings
   

   Out of scope

4. +++ b/core/tests/Drupal/KernelTests/Core/Field/FieldSettingsTest.php
   @@ -106,7 +106,7 @@ public function testConfigurableFieldSettings() {
   -      'field_setting_from_config_data' => TRUE,
   +      'field_setting_from_config_data' => 'TRUE',
   

   This seems like it should be able to stay as a Boolean, is there a fix needed elsewhere?

Out of scope

Well, they are needed in order to let phpunit not complain about it.

This seems like it should be able to stay as a Boolean, is there a fix needed elsewhere?

We debugged that earlier ... simpletest relied on casting 'TRUE' to TRUE, internally. The test though should actually expect that, see \Drupal\field_test\Plugin\Field\FieldType\TestItem::fieldSettingsFromConfigData

I'm not sure about this being 8.1.x or 8.2.x, leaving here for now.

Duh, good point about @covers \Drupal\field\Entity\FieldStorageConfig::getSettings

Looks great!

Thank you tim!

Committed c3f14f9 and pushed to 8.1.x and 8.2.x. Thanks!

As this is test only code I've committed to 8.1.x. Not cherry-picking to 8.0.x because it feels like unnecessary disruption to the production branch this late in its life cycle.

diff --git a/core/modules/system/src/Tests/Entity/EntityUnitTestBase.php b/core/modules/system/src/Tests/Entity/EntityUnitTestBase.php
index 4bdf30c..dbeb858 100644
--- a/core/modules/system/src/Tests/Entity/EntityUnitTestBase.php
+++ b/core/modules/system/src/Tests/Entity/EntityUnitTestBase.php
@@ -15,7 +15,7 @@
 /**
  * Defines an abstract test base for entity unit tests.
  *
- * @deprecated in Drupal 8.0.x, will be removed before Drupal 8.2.x. Use
+ * @deprecated in Drupal 8.1.x, will be removed before Drupal 8.2.x. Use
  *   \Drupal\KernelTests\Core\Entity\EntityKernelTestBase instead.
  */
 abstract class EntityUnitTestBase extends KernelTestBase {

Opened an issue to backport the new test class to 8.0.x: #2683391: Backport EntityKernelTestBase to 8.0.x