As per the Drupal the JavaScript code needs to follow the JavaScript coding standards. For this we use ESLint to check most of our standards.

Here is the summary of running ESLint on the 2 .js files of this GPA Calculator module:
✖ 32 problems (32 errors, 1 warnings)

Attached is the full list of errors found using ESLint.
Please find the attached patch which fixes this.

CommentFileSizeAuthor
output.txt1.69 KBpashupathi nath gajawada
gpa_calculator.patch7.13 KBpashupathi nath gajawada

Issue fork gpa_calculator-2682477

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

Pashupathi Nath Gajawada created an issue. See original summary.

avpaderno’s picture

avpaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
commented
Assigned: pashupathi nath gajawada » Unassigned
pyrello’s picture

pyrello commented
Version: 8.x-1.x-dev » 10.x-dev
Assigned: Unassigned » pyrello

pyrello opened merge request !3

pyrello credited GGH.

pyrello credited psnreddy.

pyrello’s picture

pyrello commented

Crediting the folks who opened the duplicate issues.

pyrello credited lokapujya.

pyrello’s picture

pyrello commented

Adding contributor from https://www.drupal.org/project/gpa_calculator/issues/2892830

pyrello’s picture

pyrello commented
Status: Needs review » Reviewed & tested by the community

  • pyrello committed 740efad5 on 10.x 
    Issue #2682477 by pyrello, pashupathi nath gajawada, psnreddy, lokapujya...
pyrello’s picture

pyrello commented
Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.