As of Drupal 8 all JS needs to follow our JavaScript coding standards. For this we use ESLint to check most of our standards.

Here is the summary of running ESLint on this module JS:
45 problems (45 errors, 0 warnings)

CommentFileSizeAuthor
#7 token-eslint-error-2682289-7.patch256 byteshussainweb
#2 token-eslint-error-2682289-2.patch8.35 KBneelanjana das

Comments

Neelanjana Das created an issue. See original summary.

neelanjana das’s picture

neelanjana das commented
StatusFileSize
new token-eslint-error-2682289-2.patch8.35 KB

This patch removes all the errors.

neelanjana das’s picture

neelanjana das commented
Status: Active » Needs review
neelanjana das’s picture

neelanjana das commented
Title: Token » Token ESLint error
berdir’s picture

berdir
Primary language German
Location Switzerland
commented
Status: Needs review » Needs work

jquery.treeTable.js sounds like an external library. I don't think we should change that at all.

We use 2.3.0, the latest version on http://plugins.jquery.com/treetable is 3.2.0. We should ensure that is correctly formatted. and consider using that.

hussainweb’s picture

hussainweb
Primary language English
commented

Opened #2737889: Upgrade to latest jquery treetable

hussainweb’s picture

hussainweb
Primary language English
commented
Status: Needs work » Needs review
StatusFileSize
new token-eslint-error-2682289-7.patch256 bytes

After removing the treetable changes, this is all that is left. I guess we could restructure the vendor files like core does to make it clear that this is not our code. Anyway, like @Berdir says, upgrading to 3.2.0 might fix most of the errors (and I see other fixes since 3.2.0 release as well). We are dealing with that in another issue anyway: #2737889: Upgrade to latest jquery treetable

  • Berdir committed c727e2d on 8.x-1.x authored by hussainweb 
    Issue #2682289 by Neelanjana Das, hussainweb: Fixed Token ESLint error
berdir’s picture

berdir
Primary language German
Location Switzerland
commented
Status: Needs review » Fixed

Yeah, looks like that's all now. committed.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.