Come together with the global Drupal community in Rotterdam, 28 Sept – 1 Oct 2026. Sessions, contribution, connection, and Early Bird savings until 8 June.Access manager service seems not to be used there.
https://api.drupal.org/api/drupal/core%21modules%21book%21src%21BookBrea...
| Comment | File | Size | Author |
|---|---|---|---|
| #2 | 2681903-2.patch | 2.07 KB | chi |
Comments
Comment #2
chi commentedComment #3
borisson_I think this is an API break and that means we can't do this before 9.x
Comment #4
chi commented@borisson_, how can this change break anything?
Comment #5
borisson_Changing the signature of a public method on a class that's not marked
@internalchanges the public API. I think that's something we're not allowed to do in 8.xComment #6
chi commentedThe service should be always instantiated through the service container.
Comment #7
borisson_I wasn't sure, so I looked it up, according to #2550249: [meta] Document @internal APIs both explicitly in phpdoc and implicitly in d.o documentation - this change is allowed. So setting this to RTBC.
Comment #8
catchCommitted/pushed to 8.2.x and cherry-picked to 8.1.x. Thanks!