Problem/Motivation

Continuous jobs with no selected source does nothing.

Proposed resolution

Display warning message.

Comments

CTaPByK created an issue. See original summary.

sanja_m’s picture

Assigned: Unassigned » sanja_m

Assigning to me.

sanja_m’s picture

Status: Active » Needs review
StatusFileSize
new3.27 KB

Created patch.

berdir’s picture

Status: Needs review » Needs work

I'm wondering if we're not somehow over-engineering this.

See #2679455: Add help text for overview (job, continuous job, job items, sources). As a first step, I would just add a help text for this URL, explain shortly what continuous jobs are and how they work.

Something like:

Continuous jobs allow to automatically and continuously submit all new and updated content to the configured translator. Each job has a specific language pair, multiple jobs can be created to translate into and from different languages. Only sources that match the configuration are considered, not selecting anything means that nothing will be translated with this job.

Then lets evaluate if we still need warning messages.

sanja_m’s picture

Status: Needs work » Needs review
StatusFileSize
new4.4 KB
new1.13 KB
new52.23 KB

Added help text for continuous jobs overview.

berdir’s picture

The help text is for the overview now. I meant to add that to the add form.

sanja_m’s picture

StatusFileSize
new61.75 KB
new4.39 KB
new1.43 KB

Help text moved to the add form.

miro_dietiker’s picture

Issue summary: View changes

Updating summary.
IMHO not saving is no healthy option.

And yeah, it was about usability and simplicity.
The idea was not to add complex logic to build this..

berdir’s picture

> IMHO not saving is no healthy option.

Not sure what you are saying.

IMHO, just the help text is enough, we don't need anything else.

berdir’s picture

Status: Needs review » Needs work
+++ b/tmgmt.module
@@ -1225,3 +1226,15 @@ function tmgmt_page_attachments(array &$attachments) {
+    case 'entity.tmgmt_job.continuous_add_form':
+      $output = '<h3>' . t('About continuous jobs') . '</h3>';
+      $output .= '<p>' . t('Continuous jobs allow to automatically and continuously submit all new and updated content to the configured translator. Each job has a specific language pair, multiple jobs can be created to translate into and from different languages. Only sources that match the configuration are considered, not selecting anything means that nothing will be translated with that job.') . '</p>';

not sure if we need a header, takes away a lot of space and it should be pretty clear what this is about I think.

sanja_m’s picture

Status: Needs work » Needs review
StatusFileSize
new1.59 KB
new4.09 KB

Removed header and warning message.

Status: Needs review » Needs work

The last submitted patch, 11: 2681043-11.patch, failed testing.

sanja_m’s picture

Status: Needs work » Needs review
StatusFileSize
new2 KB

Re-rolled patch from #11.

mbovan’s picture

Status: Needs review » Reviewed & tested by the community

Still applies. Looks good!

  • Berdir committed fa310cc on 8.x-1.x authored by sanja_m
    Issue #2681043 by sanja_m: Display warning massage on saving continuous...
berdir’s picture

Status: Reviewed & tested by the community » Fixed

Thanks, committed.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.