As of Drupal 8 all JS needs to follow our JavaScript coding standards. For this we use ESLint to check most of our standards.

Here is the summary of running ESLint on this module JS:
✖ 1 problems (1 errors, 0 warnings)

Attached is the full list of errors found by ESLint.

CommentFileSizeAuthor
#7 diif_eslint_errors-2680889-7.patch278 bytesjuampynr
#3 diff.patch342 bytesMurthyVittala
#2 output.txt138 bytesMurthyVittala

Comments

MurthyVittala created an issue. See original summary.

MurthyVittala’s picture

MurthyVittala commented
StatusFileSize
new output.txt138 bytes
MurthyVittala’s picture

MurthyVittala commented
StatusFileSize
new diff.patch342 bytes

Here is the Patch file to fix the js erros in Diff module.

MurthyVittala’s picture

MurthyVittala commented
Status: Active » Needs review

Status: Needs review » Needs work

The last submitted patch, 3: diff.patch, failed testing.

The last submitted patch, 3: diff.patch, failed testing.

juampynr’s picture

juampynr commented
Assigned: MurthyVittala » Unassigned
Status: Needs work » Needs review
StatusFileSize
new diif_eslint_errors-2680889-7.patch278 bytes

The patch adds an extra blank line and does not apply. Here is an updated version.

  • juampynr committed 1989491 on 8.x-1.x 
    Issue #2680889 by MurthyVittala, juampynr: Diif ESLint errors
juampynr’s picture

juampynr commented
Status: Needs review » Fixed

Committed. Thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.