Running on drupal 8.0.2
Receiving error when adding forum or container I receive wsod:
Fatal error: Call to a member function get() on null in [mysite]/modules/pathauto/src/Plugin/pathauto/AliasType/ForumAliasType.php on line 45.
I'm not able to edit or create existing and additional forums or containers.
The forum created by default is working fine.
No problem for adding topics.
| Comment | File | Size | Author |
|---|---|---|---|
| #17 | 2680503-fix-forum-integration.patch | 3.35 KB | dave reid |
| #12 | 2680503-fix-forum-integration.patch | 3.35 KB | dave reid |
| #11 | 2680503-fix-forum-integration.patch | 3.61 KB | dave reid |
| #6 | pathauto-remove-forum-alias-type-2680503.patch | 1.28 KB | berdir |
Comments
Comment #2
VBN commentedI partly solved this by removing the pattern that i used for forum nodes.
[term:vocabulary]/[term:name]
I'll create some new forums and containers first and then try to create a forum pattern again.
Wip...
Comment #3
berdirYes, the forum integration is currently completely untested and apparently broken.
Comment #4
VBN commentedSo no need to keep on testing when we know it's broken right?
Comment #5
berdirI'm wondering if we should just remove that integration for now. I've closed multiple duplicate issues already.
AFAIK, forum/ID urls are currently even broken in core. So even if our code would work, it still would be broken.
Comment #6
berdirDoing just that.
Comment #7
dave reidDoes core intend to fix the forum routing? Is there a linked issue to that?
Comment #8
berdirYes, #2010132: Canonical taxonomy term link for forum vocabulary is broken.
Comment #9
dave reidAs much as I hate the forum special-casing, I'm not sure ripping the code out is the best method. I still feel strongly about supporting core use cases for aliasing, which as long as core includes forum, we should support it. What is wrong with our current code and why can't it be fixed? Or can we just always return FALSE in the applies() method for now?
Comment #10
berdirI think workaround like that will be way more confusing than simply not having that option for now.
We can make it a critical, 1.0 blocker to add it again (with test coverage). But it just seems pointless to try and do things correctly now when core doesn't actually work with forum/N url's in the first place.
Comment #11
dave reidWe can at least get things working so when core is fixed this will work. The problem was $this->configFactory wasn't defined. I think we just need test coverage to ensure this is working as expected, instead of ripping it out.
Comment #12
dave reidUpdated some copy/paste comments.
Comment #17
dave reidErrant key strokes generally ruin testability...
Comment #18
dave reidCommitted #17 to 8.x-1.x so that I can get a new release out.