Let translators view unpublished or protected source content

Wondering about the preview URL. It doesn't really make sense, but we might want to use the new preliminary stuff here as well to be able to preview the translation? It could be a button on the form that saves and then displays the preview link?

Yeah the header was completely missing.
And the link to the source should show the untranslated source.

I also thought this issue was about offering the new preview functionality. But it seems only to be about original source content.
I think we should create a separate issue about the preview.

Anyway back to work for missing test coverage. ;-)

Just to make sure that everything works together, can we also make sure that it allows us to see unpublished sources in the test?

Do we have any tests that are testing with content entity as a source? I guess not...

I know, but that just tests the API, really. We have no test that a local translator can access an unpublished node, we don't even have a test that he can see the link to any kind of node right now.

I guess we should explicitly test this combined with an entity source test such as ContentEntitySourceUiTest?

Assigning to me.

Added some tests, still working on it, not sure what could be the problem, because there are some failing tests locally but not here.

#2682337: Add the preview feature to translator local and this issue are going to add very similar tests. I would suggest we postpone one on the other.

+++ b/translators/tmgmt_local/src/Form/LocalTaskItemForm.php
@@ -40,7 +41,60 @@ class LocalTaskItemForm extends ContentEntityForm {
+      '#type' => 'container',
+      '#attributes' => array('class' => array('tmgmt-ui-localTask-info', 'clearfix')),
+      '#weight' => 0,

mixing camel case and - is strange, use local-task.

I'd also leave out the ui in those classes. You can't have non-ui css classes, so it is useless information (I guess you copied it from tmgmt, where it is a left-over of having a tmgmt_ui module in 7.x).

So, just tmgmt-local-task-info.

The classes below are re-used, so I guess we can keep them for now.

#2682337: Add the preview feature to translator local is in now, please add your tests to the new test added there.

Updated patch.

+++ b/translators/tmgmt_local/src/Tests/LocalTranslatorPreviewTest.php
@@ -24,9 +24,14 @@ class LocalTranslatorPreviewTest extends LocalTranslatorTestBase {
    */
   public function testPreview() {
+    $user_permissions = $this->localManagerPermissions;
+    $user_permissions[] = 'view own unpublished content';
+    $this->loginAsAdmin($user_permissions);

why do you need this permission? the code below just uses the API, you shouldn't even have to log in for it.

Looks good otherwise.

Fixed bug from #19.

Nice, committed.