Abort open jobs when uninstalling a translator provider

Yeah, the uninstallation should clean up open jobs and set them to aborted. :-)

Dunno about the uninstall message... Can we add a statement there such as "All pending jobs are aborted"?

Note that #2678332: Merge normal and continuous job overviews now adds the config dependency, so uninstalling a module *will* delete those translators.

Why don't we just rely on translators that are being deleted? We prevent that in the UI, but it can still happen.

E.g. you could delete a translator through config deployment, then this should also happen. So translator post/pre delete, not module based.

Yes, that's in presave, which is an array that's not passed by reference. that's definitely broken.

What we should do is move that logic to TranslatorAccessControlHandler and prevent delete access for busy translators.

That won't prevent them from being deleted, which we have to allow as an API call and in that case, we do want to abort the jobs.

+++ /dev/null
@@ -1,29 +0,0 @@
-  public function validateForm(array &$form, FormStateInterface $form_state) {
-    parent::validateForm($form, $form_state);
-    if (tmgmt_translator_busy($this->entity->id())) {
-      $form_state->setErrorByName('tmgmt', t('This provider cannot be deleted as long as there are active jobs using it.'));
-    }
-  }

ah, that's how we did it. Not showing delete without explanation is always a bit tricky but yes, I think this makes sense, it's also annoying when it tells you you can but then not really ;)

A test that deleting through the API does this would be nice.

Nice, committed.