This issue is essetially the D7 port of #2678138: Do we need the 'enabled node types' setting? Why not just rely on view modes?. It will also fulfill #2678986: Updating AMP display mode should also update config.

Next to each content type, show enable/disable links, as well as configure links when the content type is enabled.

CommentFileSizeAuthor
#3 2678992-port-amp-config.patch13.39 KBmtift
00b273e0-dca8-11e5-8979-ffaf032c6123.png21.57 KBsirkitree

Comments

sirkitree created an issue. See original summary.

mtift’s picture

mtift
he/him
Primary language English
Location Minnesota, USA
commented
Title: Add configure links to each content type » Add enable/disable and configure links to each content type
Assigned: Unassigned » mtift
Issue summary: View changes
mtift’s picture

mtift
he/him
Primary language English
Location Minnesota, USA
commented
StatusFileSize
new 2678992-port-amp-config.patch13.39 KB

This patch does 4 things:

  1. Replicates the behavior added in #2678138: Do we need the 'enabled node types' setting? Why not just rely on view modes?
  2. Remove the node_types config from amp.settings
  3. Provides a new procedural function amp_get_enabled_types() to get an array of enabled types
  4. Caches enabled types rather than storing essentially duplicate (view mode) information in config

It still needs an update to remove old config and the procedural code needs to be converted to services

mtift’s picture

mtift
he/him
Primary language English
Location Minnesota, USA
commented
Status: Active » Fixed

I opened #2685271: Convert amp_get_enabled_types() to a service as a follow-up

  • mtift committed d053c8e on 8.x-1.x 
    Issue #2678992 by mtift: Add enable/disable and configure links to each...

  • mtift committed 133c171 on 8.x-1.x 
    Issue #2678992 by mtift: Add update hook to remove node_types from amp....

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.