Small performance improvements in commerce_customer_profile_pane_checkout_form_submit()

/**
 * Checkout pane callback: returns a customer profile edit form.
 */
function commerce_customer_profile_pane_checkout_form($form, &$form_state, $checkout_pane, $order) {
  $pane_form = array('#parents' => array($checkout_pane['pane_id']));

  // Extract the type of profile represented by this pane from its ID.
  $type = substr($checkout_pane['pane_id'], 17); // Removes 'customer_profile_'

  // Find the referenced profile using the related reference field...
  $wrapper = entity_metadata_wrapper('commerce_order', $order);
  $profile = NULL;

  // If the associated order field has been set...
  if ($field_name = variable_get('commerce_' . $checkout_pane['pane_id'] . '_field', '')) {
    // Check to ensure the specified profile reference field exists on the
    // current order type.
    if (!field_info_instance('commerce_order', $field_name, $order->type)) {
      return array();
    }

    $profile = $wrapper->{$field_name}->value();
  }

We actually do need this. And I suppose we need to review the tests.

Whoops O:) I looked at form and not submit, sorry. You are correct.

Beginning of function

  // Check to ensure the specified profile reference field exists on the
  // current order type.
  $field_name = variable_get('commerce_' . $pane_id . '_field', '');

And this portion of the patch

if ($field_name = variable_get('commerce_' . $checkout_pane['pane_id'] . '_field', '')) {

What do you think about changing the title a bit and adding this other fix: there's no need to initiate an order wrapped if the field is empty. This is only used if the field name is not empty, so it should be initiated in that same check.

  // Store the profile ID for the related field as specified on the settings form.
  $wrapper = entity_metadata_wrapper('commerce_order', $order);

:)

Looks good to me, both changes are small and don't actually change any functionality, just make things a little cleaner.

Committed.