There was a constraint in d7 that prevented users from having their username as part of their password. This needed updating to d8.

The constraint should:
* Prevent users from creating a password that contains their username

Patch coming in just a sec, tests included.

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Sophie.SK created an issue. See original summary.

Sophie.SK’s picture

Patch attached. Includes tests.

Sophie.SK’s picture

Status: Active » Needs review

Updating status.

nerdstein’s picture

Assigned: Unassigned » nerdstein

Assigning to myself to review

nerdstein’s picture

I did a code review of this.

Would this really have a checkbox in the configuration form? Under what circumstances would someone add the constraint and they would not want that box checked?

A hidden field with some description is likely more ideal.

My patch includes this.

I've tested and will be merging.

nerdstein’s picture

Status: Needs review » Fixed

Pushed to 8.x-3.x

  • nerdstein committed df0a3f5 on 8.x-3.x authored by Sophie.SK
    Issue #2678660 by Sophie.SK, nerdstein: Upgrade password username...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.