There was a constraint in d7 that prevented users from having their username as part of their password. This needed updating to d8.

The constraint should:
* Prevent users from creating a password that contains their username

Patch coming in just a sec, tests included.

CommentFileSizeAuthor
#5 password_policy-add_password_username_constraints-2678660-5.patch6.04 KBnerdstein
#2 password_policy-add_password_username_constraint-2678660-2.patch6.01 KBsophie.sk

Comments

Sophie.SK created an issue. See original summary.

sophie.sk’s picture

sophie.sk
she/her
Primary language English
commented
StatusFileSize
new password_policy-add_password_username_constraint-2678660-2.patch6.01 KB

Patch attached. Includes tests.

sophie.sk’s picture

sophie.sk
she/her
Primary language English
commented
Status: Active » Needs review

Updating status.

nerdstein’s picture

nerdstein
he/him
Primary language English
Location United States
commented
Assigned: Unassigned » nerdstein

Assigning to myself to review

nerdstein’s picture

nerdstein
he/him
Primary language English
Location United States
commented
StatusFileSize
new password_policy-add_password_username_constraints-2678660-5.patch6.04 KB

I did a code review of this.

Would this really have a checkbox in the configuration form? Under what circumstances would someone add the constraint and they would not want that box checked?

A hidden field with some description is likely more ideal.

My patch includes this.

I've tested and will be merging.

nerdstein’s picture

nerdstein
he/him
Primary language English
Location United States
commented
Status: Needs review » Fixed

Pushed to 8.x-3.x

  • nerdstein committed df0a3f5 on 8.x-3.x authored by Sophie.SK 
    Issue #2678660 by Sophie.SK, nerdstein: Upgrade password username...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.