[D7] Currency Exchanger

The module has only the .info file and there is no other file present there.

So I think, there is no need of reviewing the project application.

I also found some issues on Automated Testing, you can follow this link to check issues :

http://pareview.sh/pareview/httpgitdrupalorgsandboxkundan812670956git

Please check the automated test report http://pareview.sh/pareview/httpgitdrupalorgsandboxkundan812670956git

Full project manual review :
- You may not make this module dependent on Placeholder. This code '#placeholder' => t('0.00'), can be replaced with

'#attributes' => array(
  'placeholder' => t('0.00'),
)

However, if you may wish to still make a dependency you may need to change instructions in your README.txt file

- README.txt
Following are the changes that are required :
- Remove the word [Optional] when the module is already dependent on Placeholder (as mentioned in .info file),
- Improve documentation something like - on enabling the module, the block has to be put to a region from /admin/structure/block page. As per the current text, the user may not know this

- currency_exchanger.module
- You may have to improve css on the dropdown (can set width) - see screenshot - my current theme is Bartik

- In currency_exchanger_form_submit(), there is a security issue in $url = "https://www.google.com/finance/converter?a=$amount&from=$from&to=$to";
Please sanitize the user input through check_plain() for -

    $amount = $form_state['values']['amount'];
    $from = $form_state['values']['from'];
    $to = $form_state['values']['to'];

- Got this error, not sure why I got it the first few times I used the block. Can you please take a look at this (see screenshot)

One important thing
Can you please help us in the reviewing process and review at least 3 new projects from the issue queue. After reviewing 3 projects, you can add PAReview: review bonus tag.

Security Alert
Adding PAReview: security tag to this issue. Once resolved, you can remove this tag and review 3 more projects from the issue queue

Thanks

And correcting the previous comment , please don't remove the security tag, we keep that for statistics and to show examples of security problems.

This module seems to provide the duplicate functionality of google_currenty_converter
how your module is different from this ? please specify.

Closing due to lack of activity. If you are still working on this application, you should fix all known problems and then set the status to "Needs review". (See also the project application workflow).

I'm a robot and this is an automated message from Project Applications Scraper.