This task is to track the work around being able to place the appropriate code into the footer of the theme for AMP Pixel once that has been added to the AMP module's configuration screen.

CommentFileSizeAuthor
#7 2678276-7-amp-pixel-placement.patch7.95 KBrainbowarray
#6 2678276-6-amp-pixel-placement.patch7.87 KBrainbowarray
#5 2678276-amp-pixel-placement.patch3.62 KBrainbowarray

Comments

sirkitree created an issue. See original summary.

sirkitree’s picture

sirkitree commented
Title: AMP Pixel palcement » AMP Pixel placement
Project: AMP Theme » Amp Project
sirkitree’s picture

sirkitree commented
Project: Amp Project » Accelerated Mobile Pages (AMP)
rainbowarray’s picture

rainbowarray
she/her
Primary language English
Location Twin Cities, Minnesota
commented
Assigned: Unassigned » rainbowarray
rainbowarray’s picture

rainbowarray
she/her
Primary language English
Location Twin Cities, Minnesota
commented
Status: Active » Needs review
StatusFileSize
new 2678276-amp-pixel-placement.patch3.62 KB

This sets up the theme hook, template and placement of amp-pixel. Tried to keep this as close as possible to the D8 implementation. It seems like this should be working, but I can't get amp-pixel to show up in the markup. Not sure what's wrong. Feedback welcome!

rainbowarray’s picture

rainbowarray
she/her
Primary language English
Location Twin Cities, Minnesota
commented
StatusFileSize
new 2678276-6-amp-pixel-placement.patch7.87 KB

The amp-pixel template file was missing.

rainbowarray’s picture

rainbowarray
she/her
Primary language English
Location Twin Cities, Minnesota
commented
StatusFileSize
new 2678276-7-amp-pixel-placement.patch7.95 KB

Found the last few bugs to get this working with the help of Dave Reid and Matthew Tift.

  • mdrummond committed b659507 on 7.x-1.x 
    Issue #2678276 by mdrummond: AMP Pixel placement
rainbowarray’s picture

rainbowarray
she/her
Primary language English
Location Twin Cities, Minnesota
commented
Status: Needs review » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.