This task is to track the work around theming ad blocks for DoubleClick for Publishers and Adsense.

CommentFileSizeAuthor
#8 2678272-8-ad-block-theming.patch3.29 KBrainbowarray
#7 2678272-7-ad-block-theming.patch2.6 KBrainbowarray
#6 2678272-ad-block-theming.patch2.23 KBrainbowarray

Comments

sirkitree created an issue. See original summary.

sirkitree’s picture

sirkitree commented
Project: AMP Theme » Accelerated Mobile Pages (AMP)
rainbowarray’s picture

rainbowarray
she/her
Primary language English
Location Twin Cities, Minnesota
commented
Assigned: Unassigned » rainbowarray
rainbowarray’s picture

rainbowarray
she/her
Primary language English
Location Twin Cities, Minnesota
commented
Title: DoubleClick placement » Ad block theming
Issue summary: View changes
rainbowarray’s picture

rainbowarray
she/her
Primary language English
Location Twin Cities, Minnesota
commented
Related issues: +#2678872: Create AMP ad blocks
rainbowarray’s picture

rainbowarray
she/her
Primary language English
Location Twin Cities, Minnesota
commented
Status: Active » Needs review
StatusFileSize
new 2678272-ad-block-theming.patch2.23 KB

Seems like this should be working, but the block contents are not showing up.

rainbowarray’s picture

rainbowarray
she/her
Primary language English
Location Twin Cities, Minnesota
commented
StatusFileSize
new 2678272-7-ad-block-theming.patch2.6 KB

Missed getting the amp-ad template into the patch.

rainbowarray’s picture

rainbowarray
she/her
Primary language English
Location Twin Cities, Minnesota
commented
StatusFileSize
new 2678272-8-ad-block-theming.patch3.29 KB

This fixes the remaining issues with ad block theming.

  • mdrummond committed 0a4598a on 7.x-1.x 
    Issue #2678272 by mdrummond: Ad block theming
rainbowarray’s picture

rainbowarray
she/her
Primary language English
Location Twin Cities, Minnesota
commented
Status: Needs review » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.