Closed (fixed)
Project:
Webform
Version:
7.x-4.x-dev
Component:
Code
Priority:
Normal
Category:
Task
Assigned:
Reporter:
Created:
29 Feb 2016 at 15:50 UTC
Updated:
20 Jan 2017 at 21:04 UTC
Jump to comment: Most recent, Most recent file
I noticed that some changes could be made to the tests:
- All test classes should be in separate files.
- There shouldn't be any methods with name starting with "test" that aren't intended to be executed by the testbot.
- The WebformTestCase class should be renamed to a 'helper' class as it doesn't run any tests itself.
| Comment | File | Size | Author |
|---|---|---|---|
| #6 | webform-n2678026-6.patch | 12.74 KB | damienmckenna |
Comments
Comment #2
damienmckennaThis resolves the issues mentioned and will make it slightly easier to expand upon.
Comment #3
danchadwick commentedPatch seems to be missing the new files, no? I see tons of deleted code not moved elsewhere. Unless another webform maintainer comes out of the woodwork, I'm not sure I see this going anywhere.
Comment #4
damienmckennaOh darnit. Does this cover it?
Comment #5
damienmckenna(I hadn't reverted my local copy of the webform repo since I wrote the original above)
Comment #6
damienmckennaThis version excludes the submission.file.test file from #2675170: Drupal 7.43 makes file upload component fail for anonymous user.
Comment #7
liam morlandThis needs a reroll because of #2822962: Adjust tests to match OO best practices. Some of this ticket is done in that one.
Comment #8
liam morlandThis is entirely done in #2822962: Adjust tests to match OO best practices
Comment #9
damienmckennaAwesome!