The metatag.api.php file has several undocumented hooks. Please, please, complete this documentation and add some example code to each.

CommentFileSizeAuthor
#3 complete_api-2678004-3.patch4.35 KBalvar0hurtad0

Comments

Sutharsan created an issue. See original summary.

stkoehn’s picture

+1

alvar0hurtad0’s picture

Status: Active » Needs review
StatusFileSize
new4.35 KB

This could be the API documentation, I had some issues with those hooks:

/**
 * Never triggered.
 *
 * @deprecated
 */
function hook_metatag_config_load() {
}

/**
 * Never triggered.
 *
 * @deprecated
 */
function hook_metatag_config_load_presave() {
}

/**
 * Never triggered.
 *
 * @deprecated
 */
function hook_metatag_config_presave($config) {
}

I didn't saw any point of the code where are called, so I marked then as deprecated. If it's true I think, they can be removed from the module.

alvar0hurtad0’s picture

I forgot to comment, I've also fixed the most of the coding standards issues on this file.

damienmckenna’s picture

Status: Needs review » Fixed

So I found hook_metatag_config_presave() but I'm not sure the other two still exist.

Committed.

damienmckenna’s picture

Version: 7.x-1.13 » 7.x-1.x-dev
Status: Fixed » Needs work

Lets leave this open to continue improving the documentation.

alvar0hurtad0’s picture

Thanks :)

damienmckenna’s picture

Status: Needs work » Fixed

Will handle further improvements in #1466292: Document all Metatag's hooks.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.