Extra empty lines in Category List after Upgrade

Here is a link to the page itself

http://www.crydee.com/faq

update was run

The theme is considerably modified so best to say homebrew, though much of the work was not done by myself. It has not been changed in almost 6 months.

If you would like to see it as it was before replace "www" in the URL above with "cms2" ( I haven't supplied it as a link as I do not want it picked up by search engines and possibly indexed)

IIRC the test site is almost the same as the live site except it is running FAQ 5.x-2.4 which is what the main site upgraded from. So the change may have happened at some point inbetween.

A thought has something changed where a <br /> would have existed and is now a <p> ?

Thanks
John

Hi Stella

I implimented the patch, and the two empty lines has now reduced to one between questions, though originally there were none (IE7), In Firefox all appears Ok

Also the patch has shown that there is a large space after the description. I had a play and found that this can be changed by removing the

<p>  </p>

from

function theme_faq_category_description($term_description = '', $term_image = '') {
  $description = '';
  if (!empty($term_description)) {
    $description = '<div class="faq_qa_description"><p>';
    $description .= $term_description ."</p></div>\n";
  }

The space then appears the same size, one line that follows the Questions (IE7). Though i am not sure how that would affect other themes. At present though i have left the code as you wrote it

Oh an nice to meet another fan of Rays. (BTW The link for Feistfans at the website, is a mailing list Ray participates. in )

The Patch worked a Dream

Though i did find "check_markup" in a couple of places in the patch that were not in the module so assume they were used by yourself for testing ?

I have also added

  padding-left: 10px;

into the faq_qa_description tag in my theme to indent the description, incase you look and wonder what happened :)

Again Many thanks for a great module

John

I think i have figured out what happened. I downloaded the latest dev version but hadn't realised that it was not the version that was the basis of the patch , hence the reason i couldnt find the check_markup() in the code, and assumed it was used during testing. I will add it back in :)

The patch called for 1.1.4.63.2.51
but dev was 1.1.4.63.2.50 I must pay more attention to these little details, I assume the check_markup() appeared in .51 :)

Thanks again

Automatically closed -- issue fixed for two weeks with no activity.

Hi Stella,

The previous problemof extra space seems to have re-appeared, though i skipped 2.10 so am unsure if it appeared then.

If there is a description for the FAQ category

we get

http://www.crydee.com/faq/485

when there is no description we get

http://www.crydee.com/faq/483

It looks like the space is not collapsed when not in use

Hi Stella, many thanks for the quick response. I tried the patch, and it does reduce the gap, but it appears to be doing it by removing the "Description" . Not sure if this is how it is intended?

I did find using the following worked

  elseif (!empty($desc)) {
    $output .= '<div class="faq_qa_header">'. $term_image . $desc ."</div>\n";
  }

I think it was down to the requirement for a term image that i do not use

But as i am usure of the implication, I have removed the patch for the moment, until this is clarified

Hi Stella, works perfectly