Problem/Motivation

The manual instructions and also the JS for automatically adding it that's being worked on does not yet mention the data-embed-button attribute. Without that, you can place embeds but editing with double click doesn't work

Proposed resolution

Add data-embed-button to allowed/required attributes

Remaining tasks

User interface changes

API changes

Data model changes

CommentFileSizeAuthor
#3 data-embed-button-in-allowed-attributes-2677898-3.patch2.14 KBroyal121

Comments

Berdir created an issue. See original summary.

slashrsm’s picture

slashrsm commented
Issue tags: +Media Initiative, +D8Media, +Novice
royal121’s picture

royal121 commented
StatusFileSize
new data-embed-button-in-allowed-attributes-2677898-3.patch2.14 KB

Patch attached. Added the data-embed-button in allowed and required attributes. Please review.

royal121’s picture

royal121 commented
Status: Active » Needs review
dave reid’s picture

dave reid
he/him
Primary language English
Location Nebraska USA
commented
Status: Needs review » Needs work 
+++ b/js/plugins/drupalentity/plugin.js
@@ -84,8 +84,8 @@
+        requiredContent: 'drupal-entity[data-entity-type,data-entity-id,data-entity-uuid,data-entity-embed-display,data-entity-embed-settings,data-align,data-caption,data-embed-button]',

Note that data-embed-button should not actually be required for the preview rendering. It should only be added to allowedContent.

dave reid’s picture

dave reid
he/him
Primary language English
Location Nebraska USA
commented
Issue tags: +beta blocker
dave reid’s picture

dave reid
he/him
Primary language English
Location Nebraska USA
commented
Status: Needs work » Fixed

I think this should be resolved now. editor.addCommand('editdrupalentity' now declares data-embed-button as required and allowed.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.