From #2643692: SMS User Redesign

Add configuration path for phone number verification form (currently /verify)

Comments

dpi created an issue. See original summary.

dpi’s picture

dpi
Location Perth, Australia
commented
Assigned: Unassigned » dpi

Complted, just finishing up with some tests.

dpi’s picture

dpi
Location Perth, Australia
commented
Status: Active » Needs review

Available at https://github.com/dpi/smsframework/pull/9

  • Added new page config.
  • Refactored SmsSettingsForm
  • Sms settings form no longer redirects.
  • Added Drupal message on setttings submission.
  • Added tests, inluding new tests for sms settings form.
almaudoh’s picture

almaudoh commented

The only question I have on this issue is what need do we have to customize the verification path / url. Is there any existing use case you have?

dpi’s picture

dpi
Location Perth, Australia
commented

Localisation, or site builder preference. I've seen all kinds of configurable terminology requests, and I thought this would be a common one. (recently, changing 'register' and 'registration' terms...)

  • dpi committed 68123e8 on 8.x-1.x 
    Issue #2677664: Add configuration path for entity phone number...
dpi’s picture

dpi
Location Perth, Australia
commented
Status: Needs review » Fixed

Committed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.