Problem/Motivation

There are a couple of places where module activation is checked without using the email_verify_activated() function.

Proposed resolution

Fix them.

Remaining tasks

  1. Fix the issue
  2. Create a patch
  3. Review the patch
  4. Commit the patch

User interface changes

None.

API changes

None.

Data model changes

None.

CommentFileSizeAuthor
#5 interdiff-2676830-2-5.txt594 bytesoadaeh
#5 email_verify-check_activation_correctly-2676830-5-D7.patch3.99 KBoadaeh
#2 email_verify-check_activation_correctly-2676830-2-D7.patch4 KBoadaeh

Comments

oadaeh created an issue. See original summary.

oadaeh’s picture

oadaeh commented
Assigned: oadaeh » Unassigned
Status: Active » Needs review
StatusFileSize
new email_verify-check_activation_correctly-2676830-2-D7.patch4 KB

The attached patch makes it so that the email_verify_activated() function is used to check activation. It also sets the variable to be boolean.

aimeerae’s picture

aimeerae
she/her
Primary language English
Location San Francisco, CA
commented
Issue summary: View changes

(updating attribution)

aimeerae’s picture

aimeerae
she/her
Primary language English
Location San Francisco, CA
commented
Status: Needs review » Needs work

Looks good. I found one thing:

+++ b/email_verify.admin.inc
@@ -19,7 +19,7 @@ function email_verify_admin_settings($form, &$form_state) {
+    '#default_value' => variable_get('email_verify_active', FALSE),

Shouldn't the function be called here?

oadaeh’s picture

oadaeh commented
Status: Needs work » Needs review
StatusFileSize
new email_verify-check_activation_correctly-2676830-5-D7.patch3.99 KB
new interdiff-2676830-2-5.txt594 bytes

I've changed that in the updated patch attached.

Patrick Storey’s picture

Patrick Storey commented
Status: Needs review » Reviewed & tested by the community

This one is a tad difficult to test, but I reviewed the code and verified that it is now using the email_verify_activated() function in those areas, and while using the module no errors popped up so it appears to be using it correctly.

  • oadaeh committed 848da0b on 7.x-2.x 
    Issue #2676830 by oadaeh, Aimee Degnan, Patrick Storey: Check activation...
oadaeh’s picture

oadaeh commented
Issue summary: View changes
Status: Reviewed & tested by the community » Fixed

This has been committed to the 2.x dev branch. Thanks for the reviews and testing.

kristen pol’s picture

kristen pol
she/her
Primary language English
Location Santa Cruz, CA, USA
commented

Thanks!

kristen pol’s picture

kristen pol
she/her
Primary language English
Location Santa Cruz, CA, USA
commented

Thanks!

Whoops... duplicate. :)

oadaeh’s picture

oadaeh commented

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.