In the sync dialog, I get all the platforms and all the sites, but I came to click on the "Sync data", no matter what I have selected It always tell's me
"Are you sure you want to sync"

I have looked in the $form_state used in hosting_task_sync_form_validate, there always an empty ['values']['parameters']['source']

I could not figure why, even after messing a little with the code.

CommentFileSizeAuthor
#8 hosting_tasks_extra-sync_data_source-2674264-8.patch919 bytesgrimreaper
#3 hosting_sync-2674264-1.patch1.09 KBybabel

Comments

ybabel created an issue. See original summary.

ybabel’s picture

ybabel commented

Ok now I have a clue : it's the "A custom Drush alias" code that interferes with those of the other sources.

function hosting_task_sync_form($node) {
...
  if (1) {
    $form['source']['custom_alias'] = array(
      '#type' => 'fieldset',
...

wether its drush alias that works, wether it's platforms sites, but not both of them

ybabel’s picture

ybabel commented
StatusFileSize
new hosting_sync-2674264-1.patch1.09 KB

Proposed patch, changing the order make it works ...

ybabel’s picture

ybabel commented
Assigned: Unassigned » ybabel
Status: Active » Needs review
helmo’s picture

helmo commented

I don't like having the custom source as the first option.

We'll have to find a way to get the value of $form['source']['custom_alias']['text'] into another place.

helmo’s picture

helmo commented
Assigned: ybabel » Unassigned
Status: Needs review » Needs work
szeidler’s picture

szeidler commented

I also ran into that issue.

For future reference: You can workaround the issue, using the drush alias you initially wanted to select in the custom alias field, till there will be any progress here.

grimreaper’s picture

grimreaper
Primary language French
Location France 🇫🇷
commented
Version: 7.x-3.3 » 7.x-3.x-dev
Status: Needs work » Needs review
StatusFileSize
new hosting_tasks_extra-sync_data_source-2674264-8.patch919 bytes

Hello,

Here is a patch that fix the issue.

The problem is that the value of the hidden textfield is always send in the POST request when submitting the form. So it is an empty value.

A disabled textfield is not sent in the POST values, so disabling the textfield with the states API solved the problem.

Thanks for the review.

  • helmo committed c8d5968 on 7.x-3.x authored by Grimreaper 
    Issue #2674264 by ybabel, Grimreaper: Sync data : No sources are...
helmo’s picture

helmo commented
Status: Needs review » Fixed

Thanks, that solved it. Committed.

grimreaper’s picture

grimreaper
Primary language French
Location France 🇫🇷
commented

Thanks for the commit.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.