Job item review in preliminary state should display a message

This is for the review form.

I added a warning message in case job item is in Active/Review state and explaining the situation.

I think we should allow the administrator/user to change translation, especially when there is option to "Revert changes", which is a kind of hack to accept received ones.

The screenshot

Not related to this issue, but revision messages can be easily too long because we display full text in it... Maybe we can put it in a (one more?!) details tab...

Updated the state condition and the message:

Hm, I never managed to do this: "If we let the user edit it, we ought inform him that his changes can be overwriten by the translation"

We can change to "disabled" for a user as well.
In case translator is too lazy we can't do anything with a job/translation except waiting or abort/delete it?

We should probably wait with this task until we have preview support in the local translator that will use this. Then we will be able to properly test this manually. Right now, the patch isn't really doing what we mean.

#2682337: Add the preview feature to translator local was fixed so we can work on this one.

Updated the patch to disable translation fields and data items actions.

No tests yet. Is the message too technical?

1. +++ b/src/Form/JobItemForm.php
   @@ -36,6 +36,15 @@ class JobItemForm extends TmgmtFormBase {
   +      '#type' => 'container',
   +      '#markup' => $this->t('The data items below are in preliminary state and changes in translations are now allowed.'),
   +      '#attributes' => array(
   

   not sure if we use data items in the UI elsewhere. Maybe miro has an idea on the label?

   We could go just this job item, it doesn't really matter if it's just part or everything for the user.

2. +++ b/src/Form/JobItemForm.php
   @@ -371,11 +381,13 @@ class JobItemForm extends TmgmtFormBase {
       */
   -  function reviewFormElement(FormStateInterface $form_state, $data, JobItemInterface $job_item, &$zebra, $parent_key) {
   +  function reviewFormElement(FormStateInterface $form_state, $data, JobItemInterface $job_item, &$zebra, $parent_key, &$has_preliminary_items) {
   

   We could use $form_state get/set to avoid adding another argument here. we will do that too in the format/permission issue.

+++ b/src/Form/JobItemForm.php
@@ -36,6 +36,15 @@ class JobItemForm extends TmgmtFormBase {
+      '#markup' => $this->t('The data items below are in preliminary state and changes in translations are now allowed.'),
...
+      '#access' => FALSE,

To add a form element always and hide it with #access is a good practice for extensibility.
However, adding arbitrary messages and hiding them with #access is strange. It should only be added if needed.

data items below are in preliminary

I would simply refer to "translations". ;-)

+++ b/src/Form/JobItemForm.php
@@ -135,7 +136,18 @@ class JobItemForm extends TmgmtFormBase {
+        '#markup' => $this->t('The translations below are in preliminary state and changes in them are now allowed.'),

Missing statement is: As a result, you can not accept the item while preliminary...

Also the user should have awareness that posting a change will be overwritten by the user with any future update. (Sure, we have revisions..)

Thanks, committed with the following change:

diff --git a/src/Form/JobItemForm.php b/src/Form/JobItemForm.php
index 67b2d0e..9914e5e 100644
--- a/src/Form/JobItemForm.php
+++ b/src/Form/JobItemForm.php
@@ -140,9 +140,9 @@ class JobItemForm extends TmgmtFormBase {
     if ($form_state->get('has_preliminary_items')) {
       $form['translation_changes'] = array(
         '#type' => 'container',
-        '#markup' => $this->t('The translations below are in preliminary state and changes in them are now allowed.'),
+        '#markup' => $this->t('The translations below are in preliminary state and can not be changed.'),
         '#attributes' => array(
-          'class' => array('messages messages--warning'),
+          'class' => array('messages', 'messages--warning'),
         ),
         '#weight' => -50,
       );