Problem/Motivation

Drupal.dialog (jQuery UI) come with 2 features:
1. Modal ( with background overlay )
2. Dialog

I think Modal is used to make users focusing on content.

If set to true, the dialog will have modal behavior; other items on the page will be disabled, i.e., cannot be interacted with. Modal dialogs create an overlay below the dialog but above other page elements.

ref: http://api.jqueryui.com/dialog/#option-modal

Proposed resolution

- N / A

Remaining tasks

- Revise all Drupal.dialog usages

User interface changes

- TBA

API changes

- TBA

Data model changes

- TBA

CommentFileSizeAuthor
#7 ux_open_as_modal-2672344-7.patch424 bytesitsbakiya
#4 2672344.patch424 bytesitsbakiya
#2 add_block.png200.62 KBdarketaine

Comments

droplet created an issue. See original summary.

darketaine’s picture

darketaine commented
StatusFileSize
new add_block.png200.62 KB

I'm uploading a screenshot where this is a bug: In block layout when the vertical toolbar is open the "Place block" button opens a dialog that should have higher z-index than the toolbar

itsbakiya’s picture

itsbakiya commented
Assigned: Unassigned » itsbakiya
itsbakiya’s picture

itsbakiya commented
StatusFileSize
new 2672344.patch424 bytes

Added the patch for this

itsbakiya’s picture

itsbakiya commented
Status: Active » Needs review

Status: Needs review » Needs work

The last submitted patch, 4: 2672344.patch, failed testing.

itsbakiya’s picture

itsbakiya commented
StatusFileSize
new ux_open_as_modal-2672344-7.patch424 bytes
itsbakiya’s picture

itsbakiya commented
darketaine’s picture

darketaine commented

We should check first if changing the z-index of toolbar has a side effect on other places or else it would be better to change the z-index of modals

Version: 8.1.x-dev » 8.2.x-dev

Drupal 8.1.0-beta1 was released on March 2, 2016, which means new developments and disruptive changes should now be targeted against the 8.2.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

yoroy’s picture

yoroy commented
Related issues: +#2707291: Disable body-level scrolling when a dialog is open as a modal
Bojhan’s picture

Bojhan commented
Issue tags: -Needs usability review, -UX +Usability, +accessiblity

I am not really sure, what the a11y effects would be - I thought that was the reason for not doing this. Tagging a11y

Version: 8.2.x-dev » 8.3.x-dev

Drupal 8.2.0-beta1 was released on August 3, 2016, which means new developments and disruptive changes should now be targeted against the 8.3.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

darketaine’s picture

darketaine commented
Assigned: itsbakiya » Unassigned

Version: 8.3.x-dev » 8.4.x-dev

Drupal 8.3.0-alpha1 will be released the week of January 30, 2017, which means new developments and disruptive changes should now be targeted against the 8.4.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.4.x-dev » 8.5.x-dev

Drupal 8.4.0-alpha1 will be released the week of July 31, 2017, which means new developments and disruptive changes should now be targeted against the 8.5.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

droplet’s picture

droplet commented

Anyone able to make a final decision on this issue?

Version: 8.5.x-dev » 8.6.x-dev

Drupal 8.5.0-alpha1 will be released the week of January 17, 2018, which means new developments and disruptive changes should now be targeted against the 8.6.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.6.x-dev » 8.7.x-dev

Drupal 8.6.0-alpha1 will be released the week of July 16, 2018, which means new developments and disruptive changes should now be targeted against the 8.7.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

andrewmacpherson’s picture

andrewmacpherson commented
Issue tags: -accessiblity +Accessibility

cleaning up issues with this typo in the tag name

andrewmacpherson’s picture

andrewmacpherson commented
Status: Needs work » Closed (duplicate)

Fixed elsewhere, duplicate of #2822778: Modal popups in views is not showing properly when toolbar tray is upon modal