Closed (fixed)
Project:
Email Verify
Version:
7.x-2.x-dev
Component:
Code
Priority:
Normal
Category:
Bug report
Assigned:
Unassigned
Reporter:
Created:
15 Feb 2016 at 23:59 UTC
Updated:
25 Mar 2016 at 21:24 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #2
oadaeh commentedThe attached file fixes this.
Comment #3
oadaeh commentedOkay, so the user count/offset number were still not being handled correctly, so I re-worked the code more to come up with the new patch attached here.
There are three files:
Comment #4
oadaeh commentedDarned flaky Internet connection. Trying to re-attach the interdiffs.
Comment #5
oadaeh commentedOkay, I got one, let's get the other.
Comment #6
oadaeh commentedAttached are updated files to replace those added in #3, #4, and #5 that included some unnecessary code some code form another patch.
These files do not include that extra code.
Comment #7
oadaeh commentedAdding the third file. I didn't think the second one got added in the previous comment.
Comment #8
aimeeraeI've reviewed the code. Good work!
1) Super minor:
This seems a little odd. Text is t does not need to follow 80 characters limit but not a bit deal.
2) The queries are being built with string manipulation rather than using db_select but maybe there was some reason for that.
We'll get this tested soon.
Comment #9
Patrick Storey commentedTesting the patch in comment #6 at the /admin/people/email_verify .
I added a user with an email address that ended as .commmm to my database as user id #2.
I set the number of users to verify at 10. And the offset to 3 (so it shouldn't detect any incorrect users). Oddly it seemed to of started at the 4th user in my database.
If I set the number to 1 and the offset to 1, then it checks the 3rd user in my database (I am counting the first user as 0 assuming this is pulling from an array somewhere).
Ah, looks like there were some blocked/disabled users in the start of my database. Checked the " Include blocked/disabled users" checkbox and now the email verify is working as expected.
Okay I can verify that the offset button is working as intended. And when verifying the .commmm address it showed it in the output below as not verified with the reason being " No DNS records were found, using checkdnsrr() with "hook42.commmm." for host and "ANY" for type."
This has passed testing.
Comment #11
oadaeh commentedThis has been committed to the 2.x dev branch. Thanks for the reviews and testing.
Comment #12
oadaeh commentedComment #13
kristen polThanks!
Comment #14
oadaeh commented