In the current situation the task menu is menu-block-4 on the frontpage and can be deleted.
This problem also exists for about, organization and sub menu.

And with the current frontpage context changes, it can become a real mess.

Luckily menu_block has a beautiful hook for this problem.

CommentFileSizeAuthor
#8 define_menu_blocks_in-2669350-8.patch13.31 KBtessa bakker
#6 define_menu_blocks_in_code-2669350-6.patch28.46 KBmrharolda
#2 define_menu_blocks_in-2669350-2.patch3.85 KBtessa bakker

Comments

Tessa Bakker created an issue. See original summary.

tessa bakker’s picture

tessa bakker
she/they
Primary language Dutch
commented
Status: Active » Needs review
StatusFileSize
new define_menu_blocks_in-2669350-2.patch3.85 KB

The patch replaces the current implementation.

BarisW’s picture

BarisW commented

Great patch, Tessa. Way better than using core menu's.

Is there a way to move the existing menu's over to menu blocks in an update hook? To prevent that existing sites end up with duplicate menu's after updating DVG?

tessa bakker’s picture

tessa bakker
she/they
Primary language Dutch
commented
Status: Needs review » Needs work

Maybe cleaning up the features could be enough. I'll test the patch with an older install.

mrharolda’s picture

mrharolda commented
Assigned: Unassigned » mrharolda

Looking into this today!

mrharolda’s picture

mrharolda commented
StatusFileSize
new define_menu_blocks_in_code-2669350-6.patch28.46 KB

Here 'ya go!

* cleanup the hook_menu_block_blocks() code and added an alter.
* implemented that alter in dvg_town_council() to add the town council menu.
* added machine named menu blocks to all contexts
* deleted the now obsolete menu blocks with the numeric id's in an update hook.
* moved the front page block to the global front page context
* removed the empty/obsolete dvg_ct_block context

That's about it! After this patch; nothing should change ... but we've got rid of those pesky numeric/serial block id's! :D

mrharolda’s picture

mrharolda commented
Status: Needs work » Needs review
tessa bakker’s picture

tessa bakker
she/they
Primary language Dutch
commented
Assigned: mrharolda » Unassigned
StatusFileSize
new define_menu_blocks_in-2669350-8.patch13.31 KB

The context of Town Council wasn't updated.
Any changes to features because of the newer version of Features and Field Group are left out in the patch.

The rest works perfect, applied the patch, reverted the features and the site runs without any problems.

@BarisW, can you review the patch? So we can commit it.

BarisW’s picture

BarisW commented

I was just about to test it, but found out that is already committed ;)
Looks good to me. Thanks!

tessa bakker’s picture

tessa bakker
she/they
Primary language Dutch
commented
Status: Needs review » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.