Make paragraphs widget the default for paragraphs fields

It should be the default widget. What versions are you using?

Results in the following form display:

Picture upload, can't reference external images.

Ah yes. I think I remember that.
This is a very hard one.

ERR uses the property "default_reference_revision_settings" on the Entity Paragraph Annotations to pass these default settings when creating the field, it uses the function "getPreconfiguredOptions" on the FieldType to add those to the list. However, it does not store the selected preconfiguration when creating the field, so when you add that same field to another bundle, it does not know which preconfiguration you picked, and it also doesn't ask which one you want to pick. So then you end up with the same storage settings (as it does copy those), but with another widget (the default for that field type).

I think it's best to open a core issue about this, as it's generally odd behavior to experience.
However, we could implement a quick workaround in some hook (if exists) while the core issue is being addressed:

(warning: this code is kind of pseudo-code)

/**
 * Implements hook_field_create_instance
 */
function paragraphs_field_create_instance($instance) {
  $current_field_instances = field_get_instances($instance['entity'], $instance['field_name']);
  if (count($current_field_instances) > 1) {
    $got_all_paragraphs_targets = TRUE;
    foreach ($current_field_instances as $current_field_instance) {

      // When this isn't our own instance, and the field points to something else than Paragraphs, we should not set the widget.
      if ($current_field_instance['bundle'] != $instance['bundle'] && $current_field_instance['field_storage_config']['settings']['target_type'] != 'paragraph') {
        $got_all_paragraphs_targets = FALSE;
      }
    }
    if ($got_all_paragraphs_targets) {
      // Update $instance to get a Paragraphs widget.
      // Ugly, but it will probably work.
    }
  }
}

I'll check it out tomorrow.

-doublepost-

After the composite changes, we should try to not only default to our widget, we should hide the other widgets completely, since they must not be used anymore.

While doing so, we should also disallow creating entity reference fields to paragraphs since that will not work anymore either.

I guess we have to do form alters on the relevant core forms.

Added first try, hiding the other widgets.

But not sure about

While doing so, we should also disallow creating entity reference fields to paragraphs since that will not work anymore either.

It means that we should not be able to add entity_reference fields in a paragraph type? or that we should not be able to reference a paragraph type with a entity_reference field?

Yes, it means that if you click on Other.. for a normal reference field, in the select that you get, Paragraph should not be listed as an option.

Added second hook for hiding Paragraph as an option to be referenced by a entity_reference field. Not really sure how to implement a presave hook for set the default widget. Is it really needed?

+++ b/paragraphs.module
@@ -76,6 +76,38 @@ function paragraphs_theme_suggestions_paragraph(array $variables) {
+        unset($form['settings']['target_type']['#options']['Content'][$key]);

From Berdir: Missing t() since the key is translatable...

Note that for me without applying this patch, if i select adding a new ERR field to Paragraphs, i get the Paragraphs widget automatically selected.

@miro_dietiker yes, when you create a new ERR field the widget by default is Paragraphs but when you use it somewhere else it is set to Autocomplete. #4 explains the situation better.

Finally, what #4 describes is a core bug.

Core in FieldStorageAddForm only merges in submitForm the preconfiguredOptions, specifically of entity_form_display (Paragraphs provide, Paragraph.php, default_reference_revision_settings).

Please open the issue and refer to it in the workaround code comment.
Also workarounds like this need tests.. :-)

1. +++ b/paragraphs.module
   @@ -76,6 +76,38 @@ function paragraphs_theme_suggestions_paragraph(array $variables) {
   +function paragraphs_form_entity_form_display_edit_form_alter(&$form, \Drupal\Core\Form\FormStateInterface $form_state, $form_id) {
   +  $field_definitions = \Drupal::service('entity_field.manager')->getFieldDefinitions($form['#entity_type'], $form['#bundle']);
   +  foreach ($field_definitions as $key => $value) {
   +    if ($field_definitions[$key]->getType() == 'entity_reference_revisions') {
   +      if ($field_definitions[$key]->getSettings()['target_type'] == 'paragraph') {
   +        foreach ($form['fields'][$key]['plugin']['type']['#options'] as $option => $value) {
   +          if (in_array($option, ['options_buttons', 'options_select', 'entity_reference_revisions_autocomplete'])) {
   +            unset($form['fields'][$key]['plugin']['type']['#options'][$option]);
   +          }
   +        }
   +      }
   

   This needs some comments to explain what we're doing and why we're doing it.

2. +++ b/paragraphs.module
   @@ -76,6 +76,38 @@ function paragraphs_theme_suggestions_paragraph(array $variables) {
   +    foreach ($form['settings']['target_type']['#options']['Content'] as $key => $value) {
   +      if ($key == 'paragraph') {
   +        // Entity Reference fields are no longer supported by Paragraphs.
   +        unset($form['settings']['target_type']['#options']['Content'][$key]);
   +      }
   

   'Content' is a translatable string, you need (string) t('Content') in the key.

   Also, the loop is unnecessary, you can just unset() the key directly.

   This comment isn't very clear yet. What's not supported is entity reference fields *to* paragraphs.

Changes made based on comments above. :)

Tests added. :)

+++ b/paragraphs.module
@@ -76,6 +76,39 @@ function paragraphs_theme_suggestions_paragraph(array $variables) {
+        foreach ($form['fields'][$key]['plugin']['type']['#options'] as $option => $value) {
+          // Unset the widget display options that are no longer supported for
+          // the Paragraphs field.
+          if (in_array($option, ['options_buttons', 'options_select', 'entity_reference_revisions_autocomplete'])) {
+            unset($form['fields'][$key]['plugin']['type']['#options'][$option]);
+          }

Similar to below, I think we can simplify this, just loop over the keys you want to unset and unset them.

Also, $key is a bad variable name, use $field_name or so instaed. Same for $value, which you don't use, you could use array_keys($field_definitions) to avoid an unnecessary variable.

Also missing the core issue that we identified above.

Changed as it should. :)

Created core issue. #2717319: Provide better default configuration when re-using an existing field

Looks good. Maybe just a couple of nitpick:

+++ b/paragraphs.module
@@ -76,6 +76,35 @@ function paragraphs_theme_suggestions_paragraph(array $variables) {
+        // Loop over the display options of an err field with paragraph target
+        // type.

// Loop over ERR field's display options with paragraph target type.
Probably better above the first foreach loop.

+++ b/paragraphs.module
@@ -76,6 +76,35 @@ function paragraphs_theme_suggestions_paragraph(array $variables) {
+    // Entity Reference fields are no longer supported for referencing
+    // Paragraphs.

// Entity Reference fields are no longer supported to reference Paragraphs.

Comments changed. :)

Yep, looks great! :)

Continuing to nitpick.. :-)
For instance you comment being looping, but not why.

+++ b/src/Tests/ParagraphsAdministrationTest.php
@@ -440,6 +440,22 @@ class ParagraphsAdministrationTest extends WebTestBase {
+    // Test that entity_reference field is not supported to Paragraphs.

We are not really testing that it is "not supported". We are more testing that the unsupported situation can not be selected.

Thanks for the feedback. :)

Looks good to me.

Thx, committed. :-)

No, he didn't close it as a duplicate of this issue.

He closed it as a duplicate of the still open core issue: #2717319: Provide better default configuration when re-using an existing field.

Yes, we are aware of the problem, but the problem is in core, and we don't think this is important enough to add workarounds in paragraphs. We will fix the core issue instead.

And also you don't even need to set it as hidden and back again to Paragraphs, you can just re save it.

There is now a patch to try out on #2717319: Provide better default configuration when re-using an existing field. Once that issue is resolved, re-using a paragraph field should be a lot easier.