Now that #2640962: Theme Registry does not support switching the active theme is fixed, we can remove our workaround. Lets see if the tests still pass.

CommentFileSizeAuthor
#4 mailsystem-workaround-removed-2668030-3-interdiff.txt1.41 KBberdir
#4 mailsystem-workaround-removed-2668030-3.patch4.98 KBberdir
#2 mailsystem-workaround-removed-2668030-2.patch4.15 KBberdir

Comments

Berdir created an issue. See original summary.

berdir’s picture

berdir
Primary language German
Location Switzerland
commented
Status: Active » Needs review
StatusFileSize
new mailsystem-workaround-removed-2668030-2.patch4.15 KB

Status: Needs review » Needs work

The last submitted patch, 2: mailsystem-workaround-removed-2668030-2.patch, failed testing.

berdir’s picture

berdir
Primary language German
Location Switzerland
commented
Status: Needs work » Needs review
StatusFileSize
new mailsystem-workaround-removed-2668030-3.patch4.98 KB
new mailsystem-workaround-removed-2668030-3-interdiff.txt1.41 KB

Fixed typo.

The existing test did not properly test the core bug since the default theme registry was never initialized.

This tweaks the test so that it fails on 8.0.3 and passes on 8.0.x. Will wait with committing this until 8.0.4 is out.

  • Berdir committed 90616cb on 8.x-4.x 
    Issue #2668030 by Berdir: Remove theme registry workaround
berdir’s picture

berdir
Primary language German
Location Switzerland
commented

8.0.4 was a security release, but now 8.0.5 is out too.

berdir’s picture

berdir
Primary language German
Location Switzerland
commented
Status: Needs review » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.