Adding layout icons for each template layout so that it appears in the panelizer GUI.

CommentFileSizeAuthor
#8 templates.tar_.gz10.98 KBemptyvoid
#4 bootstrap_layout_icons-2667982-1.patch5.22 KBemptyvoid
#2 templates.tar_.gz10.92 KBemptyvoid
#2 bootstrap_layout_icons-2667982-0.patch5.77 KBemptyvoid

Comments

emptyvoid created an issue. See original summary.

emptyvoid’s picture

emptyvoid commented
StatusFileSize
new bootstrap_layout_icons-2667982-0.patch5.77 KB
new templates.tar_.gz10.92 KB
darol100’s picture

darol100 commented
Status: Active » Needs work

@emptyvoid,
Those images are seem like they are from ds_bootstrap_layouts and I have open an issue to see if they are ok if we use them. #2667476: Share images with Bootstrap Layouts. I do not want to stole someone else work if they are not ok with that.

In addition, when you are creating a patch you should create base on git instead of the packaging provide by Drupal.org. Because this will create issue like ...

+++ b/bootstrap_layouts.info.yml
@@ -1,7 +1,13 @@
+# Information added by Drupal.org packaging script on 2016-02-12
+version: '8.x-3.x-dev'
+core: '8.x'
+project: 'bootstrap_layouts'
+datestamp: 1455268140

This is should not be part of this patch.

Please remove the packaging information and lets wait until we can get an approval from #2667476: Share images with Bootstrap Layouts to see if we can use their images. Otherwise we probably need to recreate them.

emptyvoid’s picture

emptyvoid commented
StatusFileSize
new bootstrap_layout_icons-2667982-1.patch5.22 KB

Sure thing,
let me know the outcome on the images. If so I can recreate the images using the standard "gray" backgrounds used in panelizer/panels. Reusing the other module team's work as the fastest to provide the update. :)

I've removed the changes to the info.yml file from the patch.

darol100’s picture

darol100 commented

If so I can recreate the images using the standard "gray" backgrounds used in panelizer/panels.

I think it will be better for us to have generic images (icons). If you can make them on gray color I can use them into another project that I will be working Skeleton Layouts. That project will be the same project but for Skeleton framework.

So can I count on you on creating those images ?

emptyvoid’s picture

emptyvoid commented

Sure thing. watch this issue I'll post a new tar.gz with updates image.. may take a day though.

darol100’s picture

darol100 commented

I will be working on #2667534: Provide README.txt and with those icons + your patch. I think we can release a stable release of this project.

Thank you appreciate your help.

emptyvoid’s picture

emptyvoid commented
StatusFileSize
new templates.tar_.gz10.98 KB

Alright, I decided to just get it done before return to development on another module. I've recolored the pngs to follow the panels image standard.

darol100’s picture

darol100 commented
Status: Needs work » Closed (fixed)

@emptyvoid, great work, thank you for the patch and the icons.

darol100’s picture

darol100 commented

@emptyvoid, Do you still have the PSD or the image template for these icons ? There is a new layout coming up #2754249: Add four column 3-3-3-3 and four column stacked layouts, and I will like to have an icon before doing a stable-minor release.

BTW... If you can provide the icon for #2754249: Add four column 3-3-3-3 and four column stacked layouts that will be awesome.