I just created a subtheme using starter kit. Out of the box the Main Menu is not being output when placed in collapsible regions. It shows up when placed in Navigation region or in top bar, but then its not responsive.

CommentFileSizeAuthor
#6 bootstrapfixmenu-2667054-6.patch452 bytesMacronomicus

Comments

infinene created an issue. See original summary.

markhalliwell’s picture

Status: Active » Closed (cannot reproduce)
Issue tags: -navigation menu
Macronomicus’s picture

Status: Closed (cannot reproduce) » Active

im getting this too but its a bit strange, ive made two themes from the same subtheme code on two different sites, one site the collapsible works and the other nothing shows on the page at all or in the markup if its placed in collapsible.

EDIT.........................
Figured it out... To reproduce.
go to /admin/structure/block
remove all the blocks from Navigation section...
place some blocks into the Collapsible section...

Since they're tied together in page.html.twig if nothing is in the Navigation section the collapsible wont show either.

Fix
Just change lin 66 on page.html.twig to
{% if page.navigation or page.navigation_collapsible %}

Macronomicus’s picture

Status: Active » Needs review
markhalliwell’s picture

Status: Needs review » Active

No patch.

Macronomicus’s picture

Component: Starterkit (CDN) » Templates
Status: Active » Needs review
StatusFileSize
new452 bytes

sorry :0
seemed too tiny for a patch, but yea its always better with a patch.

  • neardark committed 4830132 on 8.x-3.x authored by Macronomicus
    Issue #2667054 by Macronomicus: Main Menu in collapsible region not...
neardark’s picture

Status: Needs review » Fixed

Thanks for the patch.

Macronomicus’s picture

Cheers for the awesome theme man, ive switched mine to sass and grunt but its essentially the same, such a good starting point for d8 & really flexible. Thanks for putting it out for everyone.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.