When a region is locked, the icon for that region in the IPE is an unlocked padlock. This violates a UI principle which states that you should be able to see the current state of an element in the UI. I propose changing the code and CSS to show the correct icon. This would be done in two places: where the links are created, assigning their state ('locked' or 'unlocked') and to the CSS so the class names reflect the state rather than the available action.

I'll attach a patchfile with the proposed changes.

CommentFileSizeAuthor
#3 show-current-lock-state-2666590-3.patch1.43 KBberliner
#2 show-current-lock-state-2666590-1.patch1.84 KBdmenefee

Comments

dmenefee created an issue. See original summary.

dmenefee’s picture

dmenefee commented
StatusFileSize
new show-current-lock-state-2666590-1.patch1.84 KB
berliner’s picture

berliner commented
StatusFileSize
new show-current-lock-state-2666590-3.patch1.43 KB

Patch didn't apply for me. Corrected patch attached.

berliner’s picture

berliner commented
Status: Active » Needs review

  • rabbitlair committed 9aa5249 on 7.x-1.x authored by berliner 
    Issue #2666590 by dmenefee, berliner: Lock/unlock icon does not show...
rabbitlair’s picture

rabbitlair commented
Status: Needs review » Fixed

Thank you folks! I merged the second patch, as first one was not working properly.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.