This shouldn't be necessary, because we have a proper dependency on page_manager in panels_test.info.yml, but maybe testbot changed?

In any case, the branch tests are failing because testbot isn't pulling page_manager:

https://www.drupal.org/pift-ci-job/172242

fail: [Other] Line 33 of modules/panels/src/Tests/PanelsTest.php:
Unable to install modules block, page_manager, page_manager_ui, panels_test, layout_plugin_example due to missing modules page_manager, page_manager_ui

So, let's try this!

Comments

dsnopek created an issue. See original summary.

dsnopek’s picture

Status: Active » Needs review
StatusFileSize
new262 bytes

Here's the patch!

dsnopek’s picture

Issue summary: View changes

  • japerry committed b6dbb20 on 8.x-3.x authored by dsnopek
    Issue #2666232 by dsnopek: Add page_manager to test_dependencies
    
japerry’s picture

Committed. Lets try to see if it passes now.

Status: Needs review » Needs work

The last submitted patch, 2: panels-pm-test-dependency-2666232-2.patch, failed testing.

japerry’s picture

Status: Needs work » Fixed

Fixed! It failed tests because the patch was already applied.

japerry’s picture

Status: Fixed » Needs review
StatusFileSize
new819 bytes

hmm not working. testing to see if this patch changes anything. see if panels_ipe fails!

Status: Needs review » Needs work

The last submitted patch, 8: panels-pm-test-dependency-2666232-8.patch, failed testing.

japerry’s picture

Status: Needs work » Fixed

This was fixed back with the beta4 release.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.